From: Mark Kettenis <kettenis@jive.nl>
To: sakamoto.kei@renesas.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fw: Unreviewed patch (m32r-linux support)
Date: Wed, 15 Sep 2004 11:25:00 -0000 [thread overview]
Message-ID: <200409151125.i8FBPPCe013165@juw15.nfra.nl> (raw)
In-Reply-To: <019601c49afa$1b78ce60$5169910a@E5A02646> (sakamoto.kei@renesas.com)
From: "Kei Sakamoto" <sakamoto.kei@renesas.com>
Date: Wed, 15 Sep 2004 17:00:46 +0900
Mark,
Would you review the attached patch?
I'm afraid that you are still busy because of moving.
But it seems you are the best person to review it
because I revised it based on your advise.
If you are too busy, please let me know.
Ah yes, unfortunately I've been pretty busy up until now.
Anyway, before I start giving you more ill-guided advise, can I ask
you a few question first?
Are there any plans to support the PTRACE_GETREGS/PTRACE_SETREGS
requests? I really think a modern Linux port should support those
(and only those), but Linux/M32R isn't going to support them, the code
can be simplified even more.
Are there any plans to support a FPU?
Meanwhile I have a few more comments concerning m32r-linux-tdep.c.
m32r_linux_sigtramp_start should use safe_frame_unwind_memory instead
of read_memory_unsigned_integer, otherwise there might be unwanted
interaction between signal handlers and breakpoints. Please take a
look at the recent changes to i386-linux-tdep.c to get an idea how
things should look.
Instead of rolling your own m32r_linux_svr4_fetch_link_map_offsets,
please use the generic svr4_ilp32_fetch_link_map_offsets.
Also you'll have to s/TM_FILE/DEPRECATED_TM_FILE/g in your linux.mt
file, because of some recent changes.
Hopefully, this doesn't discourage you. On the bright side, these
changes will make it easier to maintain the Linux/M32R port in the
future.
Cheers,
Mark
next prev parent reply other threads:[~2004-09-15 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 8:01 Kei Sakamoto
2004-09-15 11:25 ` Mark Kettenis [this message]
2004-09-16 4:32 ` Kei Sakamoto
2004-09-16 13:59 ` Andrew Cagney
2004-09-28 10:04 ` [RFA/m32r] revised m32r-linux patch Kei Sakamoto
2004-09-28 12:31 ` Mark Kettenis
2004-09-30 9:35 ` Kei Sakamoto
2004-10-01 0:20 ` Kei Sakamoto
2004-10-01 7:18 ` Mark Kettenis
2004-10-01 7:33 ` [commit/m32r] " Kei Sakamoto
2004-09-28 19:53 ` [RFA/m32r] " Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409151125.i8FBPPCe013165@juw15.nfra.nl \
--to=kettenis@jive.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=sakamoto.kei@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox