From: Mark Kettenis <kettenis@gnu.org>
To: sakamoto.kei@renesas.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/m32r] revised m32r-linux patch
Date: Tue, 28 Sep 2004 12:31:00 -0000 [thread overview]
Message-ID: <200409281231.i8SCV1Od019519@juw15.nfra.nl> (raw)
In-Reply-To: <01be01c4a542$82c7c010$5169910a@E5A02646> (sakamoto.kei@renesas.com)
From: "Kei Sakamoto" <sakamoto.kei@renesas.com>
Date: Tue, 28 Sep 2004 19:04:14 +0900
Hello,
I revised the patch of m32r-linux support as you adviced.
Linux/M32R kernel now supports PTRACE_GETREGS/SETREGS.
So m32r-linux uses only PTRACE_GETREGS/SETREGS.
I also replaced read_memory_unsigned_integer with
safe_frame_unwind_memory .
Great.
OK to commit?
Is this a patch against the current CVS sources? I'm asking since
your linux.mt file sets TM_FILE, but that should be
DEPRECATED_TM_FILE. Also please set it to config/tm-linux.h, and
remove config/m32r/tm-linux.h.
Oh and remove your m32r.mh file too. It's a duplicate of linux.mh and
unused. Don't forget to adjust the ChangeLog entry.
Sorry, but I'll have to ask you to resumbit the patch again. But
we're really close now.
Mark
next prev parent reply other threads:[~2004-09-28 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 8:01 Fw: Unreviewed patch (m32r-linux support) Kei Sakamoto
2004-09-15 11:25 ` Mark Kettenis
2004-09-16 4:32 ` Kei Sakamoto
2004-09-16 13:59 ` Andrew Cagney
2004-09-28 10:04 ` [RFA/m32r] revised m32r-linux patch Kei Sakamoto
2004-09-28 12:31 ` Mark Kettenis [this message]
2004-09-30 9:35 ` Kei Sakamoto
2004-10-01 0:20 ` Kei Sakamoto
2004-10-01 7:18 ` Mark Kettenis
2004-10-01 7:33 ` [commit/m32r] " Kei Sakamoto
2004-09-28 19:53 ` [RFA/m32r] " Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409281231.i8SCV1Od019519@juw15.nfra.nl \
--to=kettenis@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=sakamoto.kei@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox