From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16448 invoked by alias); 15 Sep 2004 11:25:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16326 invoked from network); 15 Sep 2004 11:25:52 -0000 Received: from unknown (HELO server7.nfra.nl) (192.87.1.57) by sourceware.org with SMTP; 15 Sep 2004 11:25:52 -0000 Received: from juw15.nfra.nl [10.87.8.15] by server7.nfra.nl; Wed, 15 Sep 2004 13:25:27 +0200 Received: from juw15.nfra.nl (localhost [127.0.0.1]) by juw15.nfra.nl (8.12.2+Sun/8.11.1) with ESMTP id i8FBPUCu013168; Wed, 15 Sep 2004 13:25:30 +0200 (CEST) Received: (from kettenis@localhost) by juw15.nfra.nl (8.12.2+Sun/8.12.2/Submit) id i8FBPPCe013165; Wed, 15 Sep 2004 13:25:25 +0200 (CEST) Date: Wed, 15 Sep 2004 11:25:00 -0000 Message-Id: <200409151125.i8FBPPCe013165@juw15.nfra.nl> From: Mark Kettenis To: sakamoto.kei@renesas.com CC: gdb-patches@sources.redhat.com In-reply-to: <019601c49afa$1b78ce60$5169910a@E5A02646> (sakamoto.kei@renesas.com) Subject: Re: Fw: Unreviewed patch (m32r-linux support) References: <019601c49afa$1b78ce60$5169910a@E5A02646> X-SW-Source: 2004-09/txt/msg00249.txt.bz2 From: "Kei Sakamoto" Date: Wed, 15 Sep 2004 17:00:46 +0900 Mark, Would you review the attached patch? I'm afraid that you are still busy because of moving. But it seems you are the best person to review it because I revised it based on your advise. If you are too busy, please let me know. Ah yes, unfortunately I've been pretty busy up until now. Anyway, before I start giving you more ill-guided advise, can I ask you a few question first? Are there any plans to support the PTRACE_GETREGS/PTRACE_SETREGS requests? I really think a modern Linux port should support those (and only those), but Linux/M32R isn't going to support them, the code can be simplified even more. Are there any plans to support a FPU? Meanwhile I have a few more comments concerning m32r-linux-tdep.c. m32r_linux_sigtramp_start should use safe_frame_unwind_memory instead of read_memory_unsigned_integer, otherwise there might be unwanted interaction between signal handlers and breakpoints. Please take a look at the recent changes to i386-linux-tdep.c to get an idea how things should look. Instead of rolling your own m32r_linux_svr4_fetch_link_map_offsets, please use the generic svr4_ilp32_fetch_link_map_offsets. Also you'll have to s/TM_FILE/DEPRECATED_TM_FILE/g in your linux.mt file, because of some recent changes. Hopefully, this doesn't discourage you. On the bright side, these changes will make it easier to maintain the Linux/M32R port in the future. Cheers, Mark