Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: neroden@twcny.rr.com (Nathanael Nerode)
To: robertmh@gnu.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] GNU/k*BSD fixes [w/ChangeLog]
Date: Mon, 09 Aug 2004 03:59:00 -0000	[thread overview]
Message-ID: <20040809035932.GA21216@twcny.rr.com> (raw)

So I was going to commit this patch 
(http://sources.redhat.com/ml/gdb-patches/2004-08/msg00192.html)
as obviously correct, but then I looked at this bit:

diff -ur src.old/gdb/i386bsd-nat.c src/gdb/i386bsd-nat.c
--- src.old/gdb/i386bsd-nat.c	2004-05-31 13:20:41.000000000 +0200
+++ src/gdb/i386bsd-nat.c	2004-08-07 03:09:50.000000000 +0200
@@ -35,6 +35,16 @@
 #include "i387-tdep.h"
 
 
+#if defined(__FreeBSD__) && !defined(__FreeBSD_kernel__)
+# define __FreeBSD_kernel__ __FreeBSD__
+#endif
+#ifdef __FreeBSD_kernel__
+# include <osreldate.h>
+# ifndef __FreeBSD_kernel_version
+#  define __FreeBSD_kernel_version __FreeBSD_version
+# endif
+#endif

...and I wondered if it is absolutely guaranteed that <osreldate.h> will
exist on all FreeBSD and FreeBSD-kernel systems of any possible vintage
supported by GDB.  Cause otherwise this could break the build on other
systems.

-- 
There are none so blind as those who will not see.


             reply	other threads:[~2004-08-09  3:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-09  3:59 Nathanael Nerode [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-08-07  2:20 Robert Millan
2004-08-09  6:59 ` Mark Kettenis
2004-08-09 16:32   ` Robert Millan
2004-08-09 17:48     ` Mark Kettenis
2004-08-09 19:19       ` Robert Millan
2004-08-09 21:25         ` Mark Kettenis
2004-08-09 22:34           ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040809035932.GA21216@twcny.rr.com \
    --to=neroden@twcny.rr.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=robertmh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox