From: Mark Kettenis <kettenis@chello.nl>
To: rmh@debian.org
Cc: gdb-patches@sources.redhat.com, glibc-bsd-hackers@nongnu.org
Subject: Re: [PATCH] GNU/k*BSD fixes [w/ChangeLog]
Date: Mon, 09 Aug 2004 06:59:00 -0000 [thread overview]
Message-ID: <200408090659.i796xKMs000507@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20040807022015.GA11745@khazad.dyndns.org> (message from Robert Millan on Sat, 7 Aug 2004 04:20:15 +0200)
Date: Sat, 7 Aug 2004 04:20:15 +0200
From: Robert Millan <rmh@debian.org>
Hi!
Please could someone apply the attached patch?
Entry for gdb/ChangeLog follows:
2004-08-07 Robert Millan <robertmh@gnu.org>
* configure.host: Match kfreebsd*-gnu and knetbsd*-gnu.
* configure.tgt: Match kfreebsd*-gnu and knetbsd*-gnu.
* bsd-kvm.c: Check for nlist.h before including it.
* i386bsd-nat.c: Match kernel of FreeBSD also with
__FreeBSD_kernel__ and __FreeBSD_kernel_version macros.
Yuck, the #ifdef mess in i386bsd-nat.c gets ugly. I think it should
be simplified. You're probably changing it to avoid the warning about
the offsets in `struct sigcontext'. If I just drop the support for
ancient BSD (which isn't used anyway) we can avoid that. You won't
get the extra check on GNU/kFreeBSD then, but as long as enough people
use GDB on normal FreeBSD/i386, this doesn't really matter.
Considering the changes to bsd-kvm.c. We shouldn't include config.h
directly. In GDB "defs.h" does that for us. I assume that GNU/k*BSD
still has libkvm. Why doesn't it have <nlist.h>? If not, then where
does it get its `struct nlist' from?
Mark
next prev parent reply other threads:[~2004-08-09 6:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-07 2:20 Robert Millan
2004-08-09 6:59 ` Mark Kettenis [this message]
2004-08-09 16:32 ` Robert Millan
2004-08-09 17:48 ` Mark Kettenis
2004-08-09 19:19 ` Robert Millan
2004-08-09 21:25 ` Mark Kettenis
2004-08-09 22:34 ` Robert Millan
2004-08-09 3:59 Nathanael Nerode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408090659.i796xKMs000507@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=glibc-bsd-hackers@nongnu.org \
--cc=rmh@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox