From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 722 invoked by alias); 9 Aug 2004 03:59:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 715 invoked from network); 9 Aug 2004 03:59:51 -0000 Received: from unknown (HELO ms-smtp-04.nyroc.rr.com) (24.24.2.58) by sourceware.org with SMTP; 9 Aug 2004 03:59:51 -0000 Received: from doctormoo (syr-24-59-117-13.twcny.rr.com [24.59.117.13]) by ms-smtp-04.nyroc.rr.com (8.12.10/8.12.10) with ESMTP id i793xUt2008947; Sun, 8 Aug 2004 23:59:31 -0400 (EDT) Received: by doctormoo (Postfix, from userid 1000) id A2C2643F60; Sun, 8 Aug 2004 23:59:32 -0400 (EDT) Date: Mon, 09 Aug 2004 03:59:00 -0000 To: robertmh@gnu.org Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] GNU/k*BSD fixes [w/ChangeLog] Message-ID: <20040809035932.GA21216@twcny.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.6+20040722i From: neroden@twcny.rr.com (Nathanael Nerode) X-Virus-Scanned: Symantec AntiVirus Scan Engine X-SW-Source: 2004-08/txt/msg00290.txt.bz2 So I was going to commit this patch (http://sources.redhat.com/ml/gdb-patches/2004-08/msg00192.html) as obviously correct, but then I looked at this bit: diff -ur src.old/gdb/i386bsd-nat.c src/gdb/i386bsd-nat.c --- src.old/gdb/i386bsd-nat.c 2004-05-31 13:20:41.000000000 +0200 +++ src/gdb/i386bsd-nat.c 2004-08-07 03:09:50.000000000 +0200 @@ -35,6 +35,16 @@ #include "i387-tdep.h" +#if defined(__FreeBSD__) && !defined(__FreeBSD_kernel__) +# define __FreeBSD_kernel__ __FreeBSD__ +#endif +#ifdef __FreeBSD_kernel__ +# include +# ifndef __FreeBSD_kernel_version +# define __FreeBSD_kernel_version __FreeBSD_version +# endif +#endif ...and I wondered if it is absolutely guaranteed that will exist on all FreeBSD and FreeBSD-kernel systems of any possible vintage supported by GDB. Cause otherwise this could break the build on other systems. -- There are none so blind as those who will not see.