Re: RFA: PowerPC sim & GDB: use fixed register numbering

[Kevin Buettner <kevinb@redhat.com>]

On 20 Jul 2004 15:39:27 -0500
Jim Blandy <jimb@redhat.com> wrote:

> gdb/ChangeLog:
> 2004-07-20  Jim Blandy  <jimb@redhat.com>
> 
> 	Use a fixed register numbering when communicating with the PowerPC
> 	simulator.
> 	* ppc-tdep.h (struct gdbarch_tdep): New member: 'sim_regno'.
> 	* rs6000-tdep.c: #include "sim-regno.h" and "gdb/sim-ppc.h".
> 	(set_sim_regno, init_sim_regno_table, rs6000_register_sim_regno): 
> 	New functions.
> 	(rs6000_gdbarch_init): Register rs6000_register_sim_regno.  Call
> 	init_sim_regno_table.
> 	* Makefile.in (gdb_sim_ppc_h): New variable.
> 	(rs6000-tdep.o): Update dependencies.

Please add a comment before each of set_sim_regno(), init_sim_regno_table(),
and rs6000_register_sim_regno() stating what each of these functions does,
the I/O behavior of any parameters, etc.

Otherwise, okay.

> include/gdb/ChangeLog:
> 2004-07-20  Jim Blandy  <jimb@redhat.com>
> 
> 	* sim-ppc.h: New file.

Okay.  (Though it's not clear to me that I need to approve this part.)

> sim/ppc/ChangeLog:
> 2004-07-20  Jim Blandy  <jimb@redhat.com>
> 
> 	Use a fixed register numbering when communicating with the PowerPC
> 	simulator.
> 	* sim_calls.c: #include "registers.h" and "gdb/sim-ppc.h"; do not
> 	include GDB's "defs.h".
> 	(gdb_register_name_table): New variable.
> 	(gdb_register_name_table_size): New enum constant.
> 	(gdb_register_name): New function.
> 	(sim_fetch_register, sim_store_register): Use gdb_register_name,
> 	instead of calling gdbarch_register_name.
> 	* Makefile.in (GDB_SIM_PPC_H): New variable.
> 	(DEFS_H): Delete variable.
> 	(sim_calls.o): Update dependencies.

Someone else needs to approve this part...

Kevin