From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8967 invoked by alias); 23 Jul 2004 23:12:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8960 invoked from network); 23 Jul 2004 23:12:56 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 23 Jul 2004 23:12:56 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6NNCue1013631 for ; Fri, 23 Jul 2004 19:12:56 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6NNCua17076 for ; Fri, 23 Jul 2004 19:12:56 -0400 Received: from localhost.localdomain (vpn50-109.rdu.redhat.com [172.16.50.109]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id i6NNCt9a009183; Fri, 23 Jul 2004 19:12:55 -0400 Received: from saguaro (saguaro.lan [192.168.64.2]) by localhost.localdomain (8.12.11/8.12.10) with SMTP id i6NNCo6O022048; Fri, 23 Jul 2004 16:12:50 -0700 Date: Fri, 23 Jul 2004 23:12:00 -0000 From: Kevin Buettner To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: PowerPC sim & GDB: use fixed register numbering Message-Id: <20040723161249.5690ea4c@saguaro> In-Reply-To: References: Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00338.txt.bz2 On 20 Jul 2004 15:39:27 -0500 Jim Blandy wrote: > gdb/ChangeLog: > 2004-07-20 Jim Blandy > > Use a fixed register numbering when communicating with the PowerPC > simulator. > * ppc-tdep.h (struct gdbarch_tdep): New member: 'sim_regno'. > * rs6000-tdep.c: #include "sim-regno.h" and "gdb/sim-ppc.h". > (set_sim_regno, init_sim_regno_table, rs6000_register_sim_regno): > New functions. > (rs6000_gdbarch_init): Register rs6000_register_sim_regno. Call > init_sim_regno_table. > * Makefile.in (gdb_sim_ppc_h): New variable. > (rs6000-tdep.o): Update dependencies. Please add a comment before each of set_sim_regno(), init_sim_regno_table(), and rs6000_register_sim_regno() stating what each of these functions does, the I/O behavior of any parameters, etc. Otherwise, okay. > include/gdb/ChangeLog: > 2004-07-20 Jim Blandy > > * sim-ppc.h: New file. Okay. (Though it's not clear to me that I need to approve this part.) > sim/ppc/ChangeLog: > 2004-07-20 Jim Blandy > > Use a fixed register numbering when communicating with the PowerPC > simulator. > * sim_calls.c: #include "registers.h" and "gdb/sim-ppc.h"; do not > include GDB's "defs.h". > (gdb_register_name_table): New variable. > (gdb_register_name_table_size): New enum constant. > (gdb_register_name): New function. > (sim_fetch_register, sim_store_register): Use gdb_register_name, > instead of calling gdbarch_register_name. > * Makefile.in (GDB_SIM_PPC_H): New variable. > (DEFS_H): Delete variable. > (sim_calls.o): Update dependencies. Someone else needs to approve this part... Kevin