From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips-irix SEGV: long doubles are 128 bits long on IRIX
Date: Thu, 22 Jul 2004 00:40:00 -0000 [thread overview]
Message-ID: <20040722003951.GA26928@nevyn.them.org> (raw)
In-Reply-To: <20040721233310.GR1278@gnat.com>
On Wed, Jul 21, 2004 at 04:33:10PM -0700, Joel Brobecker wrote:
> > > 2004-07-21 Joel Brobecker <brobecker@gnat.com>
> > >
> > > * mips-irix-tdep.c: #include "mips-tdep.h".
> > > (mips_irix_init_abi): Set size of long double to 128 bits
> > > for N32 and N64 ABIs.
> > > * Makefile.in (mips-irix-tdep.o): Add dependency on mips-tdep.h.
> > >
> > > Tested on mips-irix, fixes the problem above and many other FAILs.
> > > OK to commit?
> >
> > I can't find the right CVS tree at the moment to double-check, but I
> > think this is true for mips-linux and embedded MIPS using N32/N64 also.
>
> Do you think this is going to affect this patch? Or are you suggesting
> that we should fix mips-linux and embedded N32/N64 as well?
I'm suggesting that this change belongs in mips-tdep.c rather than in
an OSABI handler. Unfortunately I'm not set up to test on mips64-linux
at the moment (and results were pretty dismal, though not quite as bad
as Irix).
--
Daniel Jacobowitz
next prev parent reply other threads:[~2004-07-22 0:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-21 21:25 Joel Brobecker
2004-07-21 21:30 ` Daniel Jacobowitz
2004-07-21 23:33 ` Joel Brobecker
2004-07-22 0:40 ` Daniel Jacobowitz [this message]
2004-07-22 0:46 ` Joel Brobecker
2004-07-22 0:49 ` Daniel Jacobowitz
[not found] ` <mailpost.1090457371.25819@news-sj1-1>
2004-07-22 1:19 ` cgd
2004-07-22 1:27 ` Daniel Jacobowitz
2004-07-22 2:09 ` Joel Brobecker
2004-07-22 2:21 ` Daniel Jacobowitz
2004-07-22 2:34 ` Joel Brobecker
2004-07-22 2:36 ` Daniel Jacobowitz
2004-07-23 17:00 David Anderson
2004-07-26 22:18 ` Andrew Cagney
[not found] ` <mailpost.1090880398.10041@news-sj1-1>
2004-07-26 22:41 ` cgd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040722003951.GA26928@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox