From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4768 invoked by alias); 22 Jul 2004 00:40:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4761 invoked from network); 22 Jul 2004 00:40:49 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 22 Jul 2004 00:40:49 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BnRcm-00071k-DM; Wed, 21 Jul 2004 20:39:52 -0400 Date: Thu, 22 Jul 2004 00:40:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips-irix SEGV: long doubles are 128 bits long on IRIX Message-ID: <20040722003951.GA26928@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20040721212522.GP1278@gnat.com> <20040721212930.GA21706@nevyn.them.org> <20040721233310.GR1278@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040721233310.GR1278@gnat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-07/txt/msg00293.txt.bz2 On Wed, Jul 21, 2004 at 04:33:10PM -0700, Joel Brobecker wrote: > > > 2004-07-21 Joel Brobecker > > > > > > * mips-irix-tdep.c: #include "mips-tdep.h". > > > (mips_irix_init_abi): Set size of long double to 128 bits > > > for N32 and N64 ABIs. > > > * Makefile.in (mips-irix-tdep.o): Add dependency on mips-tdep.h. > > > > > > Tested on mips-irix, fixes the problem above and many other FAILs. > > > OK to commit? > > > > I can't find the right CVS tree at the moment to double-check, but I > > think this is true for mips-linux and embedded MIPS using N32/N64 also. > > Do you think this is going to affect this patch? Or are you suggesting > that we should fix mips-linux and embedded N32/N64 as well? I'm suggesting that this change belongs in mips-tdep.c rather than in an OSABI handler. Unfortunately I'm not set up to test on mips64-linux at the moment (and results were pretty dismal, though not quite as bad as Irix). -- Daniel Jacobowitz