Re: [commit] cleanup annota*.exp ``cleanup core file'' messages

Re: [commit] cleanup annota*.exp ``cleanup core file'' messages

[Michael Elizabeth Chastain]

Andrew, I asked you this yesterday:

  Andrew, you've been committing a lot of patches lately.
  Would you like to be co-maintainer of testsuite/ ?

You have a habit of ignoring questions.
This makes it difficult for me to work with you.

Michael C

Re: [commit] cleanup annota*.exp ``cleanup core file'' messages

[Andrew Cagney]

> Andrew, I asked you this yesterday:
> 
>   Andrew, you've been committing a lot of patches lately.
>   Would you like to be co-maintainer of testsuite/ ?
> 
> You have a habit of ignoring questions.
> This makes it difficult for me to work with you.

I needed to think about it, I wasn't actually expecting or looking for 
this :-)

For the moment I'd prefer not.  I've already got a number of other 
direct maintainer responsibilities (remote, MIPS, arch, target, mi), and 
I'd really like to see someone new come into the role.

Perhaphs I could be listed as an explicit ``commit''.

Andrew

PS: This flurry of activity was prompted by the need to get consistent 
test names out of the testsuite - the tests I cleaned up were all 
producing system dependant messages.

Re: [commit] cleanup annota*.exp ``cleanup core file'' messages

[Michael Elizabeth Chastain]

ac> Perhaphs I could be listed as an explicit ``commit''.

That would make me happy.

Right now the MAINTAINERS file has two things bundled together.
If somebody is listed, they have commit rights, and they have the
responsibility to review other people's patches.  I wouldn't
unbundling this a little.

How about:

  testsuite	Michael Chastain	mec.gnu@mindspring.com
  		Andrew Cagney		cagney@gnu.org
		  (authorized to commit, but not responsible to review)

ac> PS: This flurry of activity was prompted by the need to get consistent 
ac> test names out of the testsuite - the tests I cleaned up were all 
ac> producing system dependant messages.

Yeah, test names have these unwritten requirements on them, because
there are 10,000 test names and people need to run automated processing
scripts on the results.

Michael C

Re: [commit] cleanup annota*.exp ``cleanup core file'' messages

[Michael Elizabeth Chastain]

Andrew, you've been committing a lot of patches lately.

Would you like to be co-maintainer of testsuite/ ?

Michael C

===

2004-07-12  Andrew Cagney  <cagney@gnu.org>

	* gdb.base/annota1.exp: Cleanup corefile test name.
	* gdb.base/annota3.exp: Ditto.

[commit] cleanup annota*.exp ``cleanup core file'' messages

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

Hello,

Dependant on your system, and how other tests went, the annota[13].exp 
tests output different ``cleanup core file'' messages.  This fixes that.

committed,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 2323 bytes --]

2004-07-12  Andrew Cagney  <cagney@gnu.org>

	* gdb.base/annota1.exp: Cleanup corefile test name.
	* gdb.base/annota3.exp: Ditto.

Index: gdb.base/annota1.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v
retrieving revision 1.13
diff -p -u -r1.13 annota1.exp
--- gdb.base/annota1.exp	6 Nov 2003 20:50:47 -0000	1.13
+++ gdb.base/annota1.exp	12 Jul 2004 21:37:52 -0000
@@ -459,20 +459,20 @@ gdb_expect {
 }
 
 
-# Check for production of a core file
-# and remove it!
+# Check for production of a core file and remove it!
 
 set exec_output [remote_exec build "ls core"]
 
+set test "cleanup core file"
 if [ regexp "core not found" $exec_output]  {
-    pass "No core dumped"
+    pass "$test (not dumped)"
 } else {
-  if [ regexp "No such file or directory" $exec_output] {
-      pass "No core dumped"
-  } else {
-      remote_exec build "rm -f core"
-      pass "Core dumped and removed"
-  }
+    if [ regexp "No such file or directory" $exec_output] {
+	pass "$test (not dumped)"
+    } else {
+	remote_exec build "rm -f core"
+	pass "$test (removed)"
+    }
 }
 
 # restore the original prompt for the rest of the testsuite
Index: gdb.base/annota3.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota3.exp,v
retrieving revision 1.2
diff -p -u -r1.2 annota3.exp
--- gdb.base/annota3.exp	17 Aug 2003 16:50:59 -0000	1.2
+++ gdb.base/annota3.exp	12 Jul 2004 21:37:52 -0000
@@ -387,20 +387,20 @@ gdb_expect_list "signal sent" "$gdb_prom
 }
 
 
-# Check for production of a core file
-# and remove it!
+# Check for production of a core file and remove it!
 
 set exec_output [remote_exec build "ls core"]
 
+set test "cleanup core file"
 if [ regexp "core not found" $exec_output]  {
-    pass "No core dumped"
+    pass "$test (not dumped)"
 } else {
-  if [ regexp "No such file or directory" $exec_output] {
-      pass "No core dumped"
-  } else {
-      remote_exec build "rm -f core"
-      pass "Core dumped and removed"
-  }
+    if [ regexp "No such file or directory" $exec_output] {
+	pass "$test (not dumped)"
+    } else {
+	remote_exec build "rm -f core"
+	pass "$test (removed)"
+    }
 }
 
 # restore the original prompt for the rest of the testsuite