[RFA]: Top-level configure patch to build Cygwin native newlib

[RFA]: Top-level configure patch to build Cygwin native newlib

[Corinna Vinschen]

Hi,

perhaps I could just apply the patch but I would like to ask people first
if there something is in the way of applying the below patch.

The idea is the following:  If you have a source tree containing the newlib
subdir but the source tree does not contain the winsup subdir, then it's
impossible to build a native Cygwin newlib.  The reason is, that building a
Cygwin native newlib requires a bunch of header files from the winsup/cygwin
directory.  If the winsup directory is missing, the build will break when
trying to build newlib.

For that reason, the below patch to configure.in checks if the winsup
directory is available and removes newlib from the target_configdirs
if winsup is missing.

Is that ok to apply?


Corinna


	* configure.in: Don't build Cygwin native newlib if winsup
	directory is missing.
	* configure: Regenerate.


Index: configure.in
===================================================================
RCS file: /cvs/cvsfiles/gnupro/configure.in,v
retrieving revision 1.32
diff -p -u -r1.32 configure.in
--- configure.in        9 Jun 2004 17:31:01 -0000       1.32
+++ configure.in        16 Jun 2004 15:19:40 -0000
@@ -548,8 +548,8 @@ case "${target}" in
   *-*-cygwin*)
     target_configdirs="$target_configdirs target-libtermcap target-winsup"
     noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
-    # always build newlib.
-    skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
+    # always build newlib if winsup directory is present.
+    test -d winsup && skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
 
     # Can't build gdb for Cygwin if not native.
     case "${host}" in


-- 
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.

Re: [RFA]: Top-level configure patch to build Cygwin native newlib

[jjohnstn]

Hi Corinna,

  I have no problem with the patch, but would it be possible to add 
to the patch to issue a warning message to the user to tell them that 
winsup is missing?

-- Jeff J.

On Wed, 16 Jun 2004, Corinna Vinschen wrote:

> Hi,
> 
> perhaps I could just apply the patch but I would like to ask people first
> if there something is in the way of applying the below patch.
> 
> The idea is the following:  If you have a source tree containing the newlib
> subdir but the source tree does not contain the winsup subdir, then it's
> impossible to build a native Cygwin newlib.  The reason is, that building a
> Cygwin native newlib requires a bunch of header files from the winsup/cygwin
> directory.  If the winsup directory is missing, the build will break when
> trying to build newlib.
> 
> For that reason, the below patch to configure.in checks if the winsup
> directory is available and removes newlib from the target_configdirs
> if winsup is missing.
> 
> Is that ok to apply?
> 
> 
> Corinna
> 
> 
> 	* configure.in: Don't build Cygwin native newlib if winsup
> 	directory is missing.
> 	* configure: Regenerate.
> 
> 
> Index: configure.in
> ===================================================================
> RCS file: /cvs/cvsfiles/gnupro/configure.in,v
> retrieving revision 1.32
> diff -p -u -r1.32 configure.in
> --- configure.in        9 Jun 2004 17:31:01 -0000       1.32
> +++ configure.in        16 Jun 2004 15:19:40 -0000
> @@ -548,8 +548,8 @@ case "${target}" in
>    *-*-cygwin*)
>      target_configdirs="$target_configdirs target-libtermcap target-winsup"
>      noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
> -    # always build newlib.
> -    skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
> +    # always build newlib if winsup directory is present.
> +    test -d winsup && skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
>  
>      # Can't build gdb for Cygwin if not native.
>      case "${host}" in
> 
> 
> 

Re: [RFA]: Top-level configure patch to build Cygwin native newlib

[Corinna Vinschen]

On Jun 16 12:23, jjohnstn wrote:
> Hi Corinna,
> 
>   I have no problem with the patch, but would it be possible to add 
> to the patch to issue a warning message to the user to tell them that 
> winsup is missing?

No, that shouldn't be a problem.  In that case the

  test -d winsup && skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`

would become a

  if test -d winsup
  then
    skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
  else
    echo "Warning: winsup is missing so newlib can't be build."
  fi


If that's fine with everyone...

Erm... btw., should I Cc the gcc-patches list, perhaps?


Corinna



> 
> -- Jeff J.
> 
> On Wed, 16 Jun 2004, Corinna Vinschen wrote:
> 
> > Hi,
> > 
> > perhaps I could just apply the patch but I would like to ask people first
> > if there something is in the way of applying the below patch.
> > 
> > The idea is the following:  If you have a source tree containing the newlib
> > subdir but the source tree does not contain the winsup subdir, then it's
> > impossible to build a native Cygwin newlib.  The reason is, that building a
> > Cygwin native newlib requires a bunch of header files from the winsup/cygwin
> > directory.  If the winsup directory is missing, the build will break when
> > trying to build newlib.
> > 
> > For that reason, the below patch to configure.in checks if the winsup
> > directory is available and removes newlib from the target_configdirs
> > if winsup is missing.
> > 
> > Is that ok to apply?
> > 
> > 
> > Corinna
> > 
> > 
> > 	* configure.in: Don't build Cygwin native newlib if winsup
> > 	directory is missing.
> > 	* configure: Regenerate.
> > 
> > 
> > Index: configure.in
> > ===================================================================
> > RCS file: /cvs/cvsfiles/gnupro/configure.in,v
> > retrieving revision 1.32
> > diff -p -u -r1.32 configure.in
> > --- configure.in        9 Jun 2004 17:31:01 -0000       1.32
> > +++ configure.in        16 Jun 2004 15:19:40 -0000
> > @@ -548,8 +548,8 @@ case "${target}" in
> >    *-*-cygwin*)
> >      target_configdirs="$target_configdirs target-libtermcap target-winsup"
> >      noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
> > -    # always build newlib.
> > -    skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
> > +    # always build newlib if winsup directory is present.
> > +    test -d winsup && skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
> >  
> >      # Can't build gdb for Cygwin if not native.
> >      case "${host}" in
> > 
> > 
> > 

-- 
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.

Re: [RFA]: Top-level configure patch to build Cygwin native newlib

[jjohnstn]

On Wed, 16 Jun 2004, Corinna Vinschen wrote:

> On Jun 16 12:23, jjohnstn wrote:
> > Hi Corinna,
> > 
> >   I have no problem with the patch, but would it be possible to add 
> > to the patch to issue a warning message to the user to tell them that 
> > winsup is missing?
> 
> No, that shouldn't be a problem.  In that case the
> 
>   test -d winsup && skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
> 
> would become a
> 
>   if test -d winsup
>   then
>     skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
>   else
>     echo "Warning: winsup is missing so newlib can't be build."
>   fi
>

Thanks, just change "build" to "built".
  
> 
> If that's fine with everyone...
> 
> Erm... btw., should I Cc the gcc-patches list, perhaps?
>

It would be a good idea.  IIRC, most of the top-level files are 
copied by sources from gcc.  Did I get that correct, Chris?
 
> 
> Corinna
> 
> 
> 
> > 
> > -- Jeff J.
> > 
> > On Wed, 16 Jun 2004, Corinna Vinschen wrote:
> > 
> > > Hi,
> > > 
> > > perhaps I could just apply the patch but I would like to ask people first
> > > if there something is in the way of applying the below patch.
> > > 
> > > The idea is the following:  If you have a source tree containing the newlib
> > > subdir but the source tree does not contain the winsup subdir, then it's
> > > impossible to build a native Cygwin newlib.  The reason is, that building a
> > > Cygwin native newlib requires a bunch of header files from the winsup/cygwin
> > > directory.  If the winsup directory is missing, the build will break when
> > > trying to build newlib.
> > > 
> > > For that reason, the below patch to configure.in checks if the winsup
> > > directory is available and removes newlib from the target_configdirs
> > > if winsup is missing.
> > > 
> > > Is that ok to apply?
> > > 
> > > 
> > > Corinna
> > > 
> > > 
> > > 	* configure.in: Don't build Cygwin native newlib if winsup
> > > 	directory is missing.
> > > 	* configure: Regenerate.
> > > 
> > > 
> > > Index: configure.in
> > > ===================================================================
> > > RCS file: /cvs/cvsfiles/gnupro/configure.in,v
> > > retrieving revision 1.32
> > > diff -p -u -r1.32 configure.in
> > > --- configure.in        9 Jun 2004 17:31:01 -0000       1.32
> > > +++ configure.in        16 Jun 2004 15:19:40 -0000
> > > @@ -548,8 +548,8 @@ case "${target}" in
> > >    *-*-cygwin*)
> > >      target_configdirs="$target_configdirs target-libtermcap target-winsup"
> > >      noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
> > > -    # always build newlib.
> > > -    skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
> > > +    # always build newlib if winsup directory is present.
> > > +    test -d winsup && skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
> > >  
> > >      # Can't build gdb for Cygwin if not native.
> > >      case "${host}" in
> > > 
> > > 
> > > 
> 
> 

Re: [RFA]: Top-level configure patch to build Cygwin native newlib

[Alexandre Oliva]

On Jun 16, 2004, jjohnstn <jjohnstn@redhat.com> wrote:

> It would be a good idea.  IIRC, most of the top-level files are 
> copied by sources from gcc.  Did I get that correct, Chris?
 
That's correct, and configure.in is one of them.  Corinna, the patch
is fine, but please post it to gcc-patches before you check it in both
gcc and src repositories.  Thanks,

-- 
Alexandre Oliva             http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}

Re: [RFA]: Top-level configure patch to build Cygwin native newlib

[DJ Delorie]

> > It would be a good idea.  IIRC, most of the top-level files are 
> > copied by sources from gcc.  Did I get that correct, Chris?
>  
> That's correct,

No, it's not.  I or Nathanael *manually* sync the toplevel files in
*both* directions because neither side ever agreed to cede control to
the other.  I usually try to get the submitter to commit to both sides
to save us the work, though.

Re: [RFA]: Top-level configure patch to build Cygwin native newlib

[Corinna Vinschen]

Hi DJ,

On Jun 16 15:19, DJ Delorie wrote:
> 
> > > It would be a good idea.  IIRC, most of the top-level files are 
> > > copied by sources from gcc.  Did I get that correct, Chris?
> >  
> > That's correct,
> 
> No, it's not.  I or Nathanael *manually* sync the toplevel files in
> *both* directions because neither side ever agreed to cede control to
> the other.  I usually try to get the submitter to commit to both sides
> to save us the work, though.

the problem here is that I don't have checkin permissions on the gcc
repository.  I've applied the below patch now to the sourceware repository. 
It would be nice if you could pick it up for gcc.

Thanks,
Corinna


2004-06-17  Corinna Vinschen  <vinschen@redhat.com>

	* configure.in: Don't build Cygwin native newlib if winsup
	directory is missing.  Emit warning instead.
	* configure: Regenerate.


Index: configure.in
===================================================================
RCS file: /cvs/src/src/configure.in,v
retrieving revision 1.220
diff -p -u -r1.220 configure.in
--- configure.in        9 Jun 2004 08:32:34 -0000       1.220
+++ configure.in        17 Jun 2004 07:54:33 -0000
@@ -585,8 +585,13 @@ case "${target}" in
   *-*-cygwin*)
     target_configdirs="$target_configdirs target-libtermcap target-winsup"
     noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
-    # always build newlib.
-    skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
+    # always build newlib if winsup directory is present.
+    if test -d winsup
+    then
+      skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
+    else
+      echo "Warning: winsup is missing so newlib can't be built."
+    fi
 
     # Can't build gdb for Cygwin if not native.
     case "${host}" in


-- 
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.

Re: [RFA]: Top-level configure patch to build Cygwin native newlib

[DJ Delorie]

> the problem here is that I don't have checkin permissions on the gcc
> repository.  I've applied the below patch now to the sourceware repository. 
> It would be nice if you could pick it up for gcc.

FYI you used an older version of autoconf to regenerate configure.
Please actually review the diffs when you regenerate files and make
sure you don't change more than you should.