From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15334 invoked by alias); 16 Jun 2004 17:47:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15297 invoked from network); 16 Jun 2004 17:47:34 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 16 Jun 2004 17:47:34 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5GHlYe1027739; Wed, 16 Jun 2004 13:47:34 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5GHlX010144; Wed, 16 Jun 2004 13:47:33 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id i5GHlXtn028874; Wed, 16 Jun 2004 13:47:33 -0400 Received: from tooth.toronto.redhat.com (tooth.toronto.redhat.com [172.16.14.29]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 82B61800326; Wed, 16 Jun 2004 13:47:33 -0400 (EDT) Date: Wed, 16 Jun 2004 17:47:00 -0000 From: jjohnstn X-X-Sender: jjohnstn@tooth.toronto.redhat.com To: Corinna Vinschen Cc: gdb-patches@sources.redhat.com, , Subject: Re: [RFA]: Top-level configure patch to build Cygwin native newlib In-Reply-To: <20040616165152.GJ1365@cygbert.vinschen.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2004-06/txt/msg00385.txt.bz2 On Wed, 16 Jun 2004, Corinna Vinschen wrote: > On Jun 16 12:23, jjohnstn wrote: > > Hi Corinna, > > > > I have no problem with the patch, but would it be possible to add > > to the patch to issue a warning message to the user to tell them that > > winsup is missing? > > No, that shouldn't be a problem. In that case the > > test -d winsup && skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'` > > would become a > > if test -d winsup > then > skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'` > else > echo "Warning: winsup is missing so newlib can't be build." > fi > Thanks, just change "build" to "built". > > If that's fine with everyone... > > Erm... btw., should I Cc the gcc-patches list, perhaps? > It would be a good idea. IIRC, most of the top-level files are copied by sources from gcc. Did I get that correct, Chris? > > Corinna > > > > > > > -- Jeff J. > > > > On Wed, 16 Jun 2004, Corinna Vinschen wrote: > > > > > Hi, > > > > > > perhaps I could just apply the patch but I would like to ask people first > > > if there something is in the way of applying the below patch. > > > > > > The idea is the following: If you have a source tree containing the newlib > > > subdir but the source tree does not contain the winsup subdir, then it's > > > impossible to build a native Cygwin newlib. The reason is, that building a > > > Cygwin native newlib requires a bunch of header files from the winsup/cygwin > > > directory. If the winsup directory is missing, the build will break when > > > trying to build newlib. > > > > > > For that reason, the below patch to configure.in checks if the winsup > > > directory is available and removes newlib from the target_configdirs > > > if winsup is missing. > > > > > > Is that ok to apply? > > > > > > > > > Corinna > > > > > > > > > * configure.in: Don't build Cygwin native newlib if winsup > > > directory is missing. > > > * configure: Regenerate. > > > > > > > > > Index: configure.in > > > =================================================================== > > > RCS file: /cvs/cvsfiles/gnupro/configure.in,v > > > retrieving revision 1.32 > > > diff -p -u -r1.32 configure.in > > > --- configure.in 9 Jun 2004 17:31:01 -0000 1.32 > > > +++ configure.in 16 Jun 2004 15:19:40 -0000 > > > @@ -548,8 +548,8 @@ case "${target}" in > > > *-*-cygwin*) > > > target_configdirs="$target_configdirs target-libtermcap target-winsup" > > > noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}" > > > - # always build newlib. > > > - skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'` > > > + # always build newlib if winsup directory is present. > > > + test -d winsup && skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'` > > > > > > # Can't build gdb for Cygwin if not native. > > > case "${host}" in > > > > > > > > > > >