From: Daniel Jacobowitz <drow@false.org>
To: Jim Blandy <jimb@redhat.com>
Cc: Paul Hilfinger <hilfingr@gnat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Turn on Ada support
Date: Wed, 09 Jun 2004 13:12:00 -0000 [thread overview]
Message-ID: <20040609131240.GA7587@nevyn.them.org> (raw)
In-Reply-To: <vt2aczd8aah.fsf@zenia.home>
On Wed, Jun 09, 2004 at 02:23:18AM -0500, Jim Blandy wrote:
>
> The changes to symtab.c, symfile.c, defs.h, and gdbtypes.h are fine.
>
> I don't like the braces around the lone 'return' statements in
> symtab.c, though. I don't think they add much, although what's
> probably more germane is that it's not the typical practice elsewhere
> in the code.
I'm not sure if those parts will work without the Makefile.in changes,
and I'm not in favor of the Makefile.in changes yet.
The problem is that the Ada language support has never been reviewed.
It's in the repository as a code dump under the assumption that it will
be reviewed before we start actively using it. So in my opinion, to
review this patch we first have to review those files.
--
Daniel Jacobowitz
next prev parent reply other threads:[~2004-06-09 13:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 9:08 Paul Hilfinger
2004-06-08 22:15 ` Eli Zaretskii
2004-06-09 9:23 ` Paul Hilfinger
2004-06-09 18:25 ` Eli Zaretskii
2004-06-10 9:40 ` Paul Hilfinger
2004-06-09 7:24 ` Jim Blandy
2004-06-09 9:40 ` Paul Hilfinger
2004-06-09 13:12 ` Daniel Jacobowitz [this message]
2004-06-09 13:40 ` Andrew Cagney
2004-06-09 16:21 ` Jim Blandy
2004-06-10 9:50 ` Paul Hilfinger
2004-06-16 8:42 ` [RFA]: Turn on Ada support, take 2 Paul Hilfinger
2004-06-16 18:07 ` Eli Zaretskii
2004-06-17 5:24 ` Paul Hilfinger
2004-06-17 17:48 ` Eli Zaretskii
2004-06-16 8:34 ` [PATCH]: Further updates to ada-* files Paul Hilfinger
2004-06-27 0:10 ` Andrew Cagney
2004-06-27 8:56 ` Paul Hilfinger
2004-06-28 14:47 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040609131240.GA7587@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=hilfingr@gnat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox