From: Paul Hilfinger <hilfingr@gnat.com>
To: jimb@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Turn on Ada support
Date: Wed, 09 Jun 2004 09:40:00 -0000 [thread overview]
Message-ID: <20040609094016.4F901F2956@nile.gnat.com> (raw)
In-Reply-To: <vt2aczd8aah.fsf@zenia.home> (message from Jim Blandy on 09 Jun 2004 02:23:18 -0500)
> The changes to symtab.c, symfile.c, defs.h, and gdbtypes.h are fine.
>
> I don't like the braces around the lone 'return' statements in
> symtab.c, though. I don't think they add much, although what's
> probably more germane is that it's not the typical practice elsewhere
> in the code.
Jim,
Great! I'll remove the braces; they're probably an artifact of some
internal change sequence anyway.
Paul
next prev parent reply other threads:[~2004-06-09 9:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 9:08 Paul Hilfinger
2004-06-08 22:15 ` Eli Zaretskii
2004-06-09 9:23 ` Paul Hilfinger
2004-06-09 18:25 ` Eli Zaretskii
2004-06-10 9:40 ` Paul Hilfinger
2004-06-09 7:24 ` Jim Blandy
2004-06-09 9:40 ` Paul Hilfinger [this message]
2004-06-09 13:12 ` Daniel Jacobowitz
2004-06-09 13:40 ` Andrew Cagney
2004-06-09 16:21 ` Jim Blandy
2004-06-10 9:50 ` Paul Hilfinger
2004-06-16 8:42 ` [RFA]: Turn on Ada support, take 2 Paul Hilfinger
2004-06-16 18:07 ` Eli Zaretskii
2004-06-17 5:24 ` Paul Hilfinger
2004-06-17 17:48 ` Eli Zaretskii
2004-06-16 8:34 ` [PATCH]: Further updates to ada-* files Paul Hilfinger
2004-06-27 0:10 ` Andrew Cagney
2004-06-27 8:56 ` Paul Hilfinger
2004-06-28 14:47 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040609094016.4F901F2956@nile.gnat.com \
--to=hilfingr@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox