From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18694 invoked by alias); 9 Jun 2004 09:40:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18681 invoked from network); 9 Jun 2004 09:40:17 -0000 Received: from unknown (HELO nile.gnat.com) (205.232.38.5) by sourceware.org with SMTP; 9 Jun 2004 09:40:17 -0000 Received: from localhost (localhost [127.0.0.1]) by nile.gnat.com (Postfix) with ESMTP id 9D0EAF2818; Wed, 9 Jun 2004 05:40:16 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 26954-01-9; Wed, 9 Jun 2004 05:40:16 -0400 (EDT) Received: by nile.gnat.com (Postfix, from userid 1345) id 4F901F2956; Wed, 9 Jun 2004 05:40:16 -0400 (EDT) From: Paul Hilfinger To: jimb@redhat.com Cc: gdb-patches@sources.redhat.com In-reply-to: (message from Jim Blandy on 09 Jun 2004 02:23:18 -0500) Subject: Re: [RFA]: Turn on Ada support References: <20040608090758.C59CAF2940@nile.gnat.com> Message-Id: <20040609094016.4F901F2956@nile.gnat.com> Date: Wed, 09 Jun 2004 09:40:00 -0000 X-Virus-Scanned: by amavisd-new at nile.gnat.com X-SW-Source: 2004-06/txt/msg00167.txt.bz2 > The changes to symtab.c, symfile.c, defs.h, and gdbtypes.h are fine. > > I don't like the braces around the lone 'return' statements in > symtab.c, though. I don't think they add much, although what's > probably more germane is that it's not the typical practice elsewhere > in the code. Jim, Great! I'll remove the braces; they're probably an artifact of some internal change sequence anyway. Paul