From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4954 invoked by alias); 9 Jun 2004 13:12:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4929 invoked from network); 9 Jun 2004 13:12:42 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 9 Jun 2004 13:12:42 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BY2si-00020R-GR; Wed, 09 Jun 2004 09:12:40 -0400 Date: Wed, 09 Jun 2004 13:12:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: Paul Hilfinger , gdb-patches@sources.redhat.com Subject: Re: [RFA]: Turn on Ada support Message-ID: <20040609131240.GA7587@nevyn.them.org> Mail-Followup-To: Jim Blandy , Paul Hilfinger , gdb-patches@sources.redhat.com References: <20040608090758.C59CAF2940@nile.gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-06/txt/msg00169.txt.bz2 On Wed, Jun 09, 2004 at 02:23:18AM -0500, Jim Blandy wrote: > > The changes to symtab.c, symfile.c, defs.h, and gdbtypes.h are fine. > > I don't like the braces around the lone 'return' statements in > symtab.c, though. I don't think they add much, although what's > probably more germane is that it's not the typical practice elsewhere > in the code. I'm not sure if those parts will work without the Makefile.in changes, and I'm not in favor of the Makefile.in changes yet. The problem is that the Ada language support has never been reviewed. It's in the repository as a code dump under the assumption that it will be reviewed before we start actively using it. So in my opinion, to review this patch we first have to review those files. -- Daniel Jacobowitz