Re: [patch/rfc] mark structs2.exp tests as kfail on hppa

Re: [patch/rfc] mark structs2.exp tests as kfail on hppa

[Michael Elizabeth Chastain]

> Should i mark the test as kfailed? I don't know what's the "common
> practice" for marking gcc bugs in gdb test cases...

"KFAIL" means known failure inside gdb.
"XFAIL" means expected failure in something outside gdb (like gcc).

So these would be XFAIL's.  setup_xfail has a three-argument form
so you can say "setup_xfail hppa-*-* gcc/15860".

And if you wanna be real fussy:

  if { [ test_compiler_info gcc-*-* ] } then {
    setup_xfail hppa-*-* gcc/15860
  }

Michael C

Re: [patch/rfc] mark structs2.exp tests as kfail on hppa

[Randolph Chung]

> "KFAIL" means known failure inside gdb.
> "XFAIL" means expected failure in something outside gdb (like gcc).
> 
> So these would be XFAIL's.  setup_xfail has a three-argument form
> so you can say "setup_xfail hppa-*-* gcc/15860".

thanks.

updated patch follows, if we want to put this in..

randolph


2004-06-07  Randolph Chung  <tausq@debian.org>

	* gdb.base/structs2.exp: Mark two tests as xfail because of a compiler
	problem.

Index: gdb.base/structs2.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/structs2.exp,v
retrieving revision 1.2
diff -u -p -r1.2 structs2.exp
--- gdb.base/structs2.exp	6 Mar 2001 08:21:51 -0000	1.2
+++ gdb.base/structs2.exp	7 Jun 2004 19:10:47 -0000
@@ -29,6 +29,12 @@ set testfile "structs2"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
 
+# Create and source the file that provides information about the compiler
+# used to compile the test case.
+if [get_compiler_info ${binfile}] {
+    return -1;
+}
+
 # build the first test case
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
     # built the second test case since we can't use prototypes
@@ -64,10 +70,16 @@ gdb_test "break param_reg" \
     "Breakpoint .* at .*" \
     "structs2 breakpoint set"
 
+if { [ test_compiler_info gcc-*-* ] } then {
+  setup_xfail hppa*-* gcc/15860
+}
 gdb_test "continue" \
     ".*pr_char=120.*pr_uchar=130.*pr_short=32000.*pr_ushort=33000.*bkpt = 1.*" \
     "structs2 continue1"
 
+if { [ test_compiler_info gcc-*-* ] } then {
+  setup_xfail hppa*-* gcc/15860
+}
 gdb_test "continue" \
     ".*pr_char=-126.*pr_uchar=120.*pr_short=-32536.*pr_ushort=32000.*bkpt = 1.*" \
     "structs2 continue2"

Re: [patch/rfc] mark structs2.exp tests as kfail on hppa

[Andrew Cagney]

Ok, with a tweak.  Can you white-space this:

> +if { [ test_compiler_info gcc-*-* ] } then {
> +  setup_xfail hppa*-* gcc/15860
> +}

more like this:

 > if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" 
executable {debug}] != "" } {

(the "[]")

Andrew

[patch/rfc] mark structs2.exp tests as kfail on hppa

[Randolph Chung]

This is related to
http://sources.redhat.com/ml/gdb/2004-03/msg00043.html

Dan helped me look at this a bit more. The details are in a gcc bug
report:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15860

Should i mark the test as kfailed? I don't know what's the "common
practice" for marking gcc bugs in gdb test cases...

of course, this is also not entirely accurate, since the problem seems
to be with gcc and not the architecture itself.

randolph

2004-06-07  Randolph Chung  <tausq@debian.org>

	* gdb.base/structs2.exp: Mark two tests as kfail because of a compiler
	problem.

Index: gdb.base/structs2.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/structs2.exp,v
retrieving revision 1.2
diff -u -p -r1.2 structs2.exp
--- gdb.base/structs2.exp	6 Mar 2001 08:21:51 -0000	1.2
+++ gdb.base/structs2.exp	7 Jun 2004 18:34:02 -0000
@@ -64,10 +64,12 @@ gdb_test "break param_reg" \
     "Breakpoint .* at .*" \
     "structs2 breakpoint set"
 
+setup_kfail "hppa*-*" gcc/15860
 gdb_test "continue" \
     ".*pr_char=120.*pr_uchar=130.*pr_short=32000.*pr_ushort=33000.*bkpt = 1.*" \
     "structs2 continue1"
 
+setup_kfail "hppa*-*" gcc/15860
 gdb_test "continue" \
     ".*pr_char=-126.*pr_uchar=120.*pr_short=-32536.*pr_ushort=32000.*bkpt = 1.*" \
     "structs2 continue2"
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/