From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
To: randolph@tausq.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commited] small changes to fix hpux-cc compile
Date: Sun, 16 May 2004 15:55:00 -0000 [thread overview]
Message-ID: <20040516155532.8F75E4B104@berman.michael-chastain.com> (raw)
> Yes, this was indeed my thinking and why i hardcoded it.
So what happens if your hardcoded auto array of size 4 ever overflows?
We get a nasty bit of stack corruption. I hate seeing code like this
creep into gdb. It works until something else changes and then it
quietly crashes or prints random bad results.
The reason this code stopped compiling is that TARGET_INT_BIT became
more dynamic; it changed from a manifest constant to a function call.
char dld_flags_buffer[4];
...
status = target_read_memory (addr, dld_flags_buffer, TARGET_INT_BIT / TARGET_CHAR_BIT);
That's just wrong!
Michael C
next reply other threads:[~2004-05-16 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-16 15:55 Michael Elizabeth Chastain [this message]
2004-05-16 17:21 ` Randolph Chung
-- strict thread matches above, loose matches on Subject: below --
2004-05-16 18:46 Michael Elizabeth Chastain
2004-05-16 10:12 Michael Elizabeth Chastain
2004-05-16 10:33 ` Mark Kettenis
2004-05-16 15:32 ` Randolph Chung
2004-05-16 4:35 Randolph Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040516155532.8F75E4B104@berman.michael-chastain.com \
--to=mec.gnu@mindspring.com \
--cc=gdb-patches@sources.redhat.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox