Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: mec.gnu@mindspring.com
Cc: gdb-patches@sources.redhat.com, randolph@tausq.org
Subject: Re: [commited] small changes to fix hpux-cc compile
Date: Sun, 16 May 2004 10:33:00 -0000	[thread overview]
Message-ID: <200405161032.i4GAWp8q002490@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20040516101223.635BF4B104@berman.michael-chastain.com>

   Date: Sun, 16 May 2004 06:12:23 -0400 (EDT)
   From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)

   Hi Randolph,

   In this change:

     -  char dld_flags_buffer[TARGET_INT_BIT / TARGET_CHAR_BIT];
     +  char dld_flags_buffer[4];

   I just ran into the same problem with TARGET_INT_BIT so I understand
   why this needs to change.  But why 4?  What if the target configuration
   has 64-bit ints?

The question should be: will there ever be a target that uses SOM that
doesn't use 32-bit ints?  I think we can be fairly certain that there
won't be such target in the future.  HP already has abandoned SOM in
favour of ELF of 64-bit HP-UX, and even that still has 32-bit ints.
As a matter of fact, I'm not aware of any ABI that has 64-bit ints.
But in general:

   How about this instead:

     char * dld_flags_buffer = alloca(TARGET_INT_BIT/TARGET_CHAR_BIT);

This is indeed the right approach.

Mark


  reply	other threads:[~2004-05-16 10:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-16 10:12 Michael Elizabeth Chastain
2004-05-16 10:33 ` Mark Kettenis [this message]
2004-05-16 15:32   ` Randolph Chung
  -- strict thread matches above, loose matches on Subject: below --
2004-05-16 18:46 Michael Elizabeth Chastain
2004-05-16 15:55 Michael Elizabeth Chastain
2004-05-16 17:21 ` Randolph Chung
2004-05-16  4:35 Randolph Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405161032.i4GAWp8q002490@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec.gnu@mindspring.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox