Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Randolph Chung <randolph@tausq.org>
To: Mark Kettenis <kettenis@chello.nl>
Cc: mec.gnu@mindspring.com, gdb-patches@sources.redhat.com
Subject: Re: [commited] small changes to fix hpux-cc compile
Date: Sun, 16 May 2004 15:32:00 -0000	[thread overview]
Message-ID: <20040516153207.GI566@tausq.org> (raw)
In-Reply-To: <200405161032.i4GAWp8q002490@elgar.kettenis.dyndns.org>

> The question should be: will there ever be a target that uses SOM that
> doesn't use 32-bit ints?  I think we can be fairly certain that there
> won't be such target in the future.  HP already has abandoned SOM in
> favour of ELF of 64-bit HP-UX, and even that still has 32-bit ints.
> As a matter of fact, I'm not aware of any ABI that has 64-bit ints.

Yes, this was indeed my thinking and why i hardcoded it.

> But in general:
> 
>    How about this instead:
> 
>      char * dld_flags_buffer = alloca(TARGET_INT_BIT/TARGET_CHAR_BIT);
> 
> This is indeed the right approach.

actually in the code:

  unsigned int dld_flags_value;
[...]
  dld_flags_value = extract_unsigned_integer (dld_flags_buffer,
                                              sizeof (dld_flags_value));

so the code does not anyway allow dld_flags_value to be 64-bit. (i don't
think anyone ever does 64-bit int's, right?)

randolph
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/


  reply	other threads:[~2004-05-16 15:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-16 10:12 Michael Elizabeth Chastain
2004-05-16 10:33 ` Mark Kettenis
2004-05-16 15:32   ` Randolph Chung [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-05-16 18:46 Michael Elizabeth Chastain
2004-05-16 15:55 Michael Elizabeth Chastain
2004-05-16 17:21 ` Randolph Chung
2004-05-16  4:35 Randolph Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040516153207.GI566@tausq.org \
    --to=randolph@tausq.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    --cc=mec.gnu@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox