From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [patch] Test scalar call/return/finish test - call-sc
Date: Sun, 25 Apr 2004 14:27:00 -0000 [thread overview]
Message-ID: <20040425142706.GA29555@nevyn.them.org> (raw)
In-Reply-To: <200404251144.i3PBiaB6019886@elgar.kettenis.dyndns.org>
On Sun, Apr 25, 2004 at 01:44:36PM +0200, Mark Kettenis wrote:
> Anyway, can anybody shoot any holes in my new regexp?
> - -re "type = (\[^\\r\\n\]*).*$gdb_prompt $" {
> + -re "type = (.*)\r\n.*$gdb_prompt $" {
Should work - but I'd do this instead, if it works:
-re "type = (\[^\r\n\]*)\r\n$gdb_prompt $"
No reason to use .* unnecessarily, and this prevents an error message
from appearing after the ptype and not being caught. Our testsuite is
very bad about that.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-04-25 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-24 0:03 Andrew Cagney
2004-04-24 18:20 ` Joel Brobecker
2004-04-25 11:44 ` Mark Kettenis
2004-04-25 14:27 ` Daniel Jacobowitz [this message]
2004-04-26 0:53 ` Joel Brobecker
2004-04-28 0:16 ` Mark Kettenis
2004-04-28 15:49 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040425142706.GA29555@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox