From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28973 invoked by alias); 25 Apr 2004 14:27:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28961 invoked from network); 25 Apr 2004 14:27:07 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 25 Apr 2004 14:27:07 -0000 Received: from drow by nevyn.them.org with local (Exim 4.32 #1 (Debian)) id 1BHkb4-0007hr-Qj for ; Sun, 25 Apr 2004 10:27:06 -0400 Date: Sun, 25 Apr 2004 14:27:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [patch] Test scalar call/return/finish test - call-sc Message-ID: <20040425142706.GA29555@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <4089AD34.90607@gnu.org> <20040424182018.GN2811@gnat.com> <200404251144.i3PBiaB6019886@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200404251144.i3PBiaB6019886@elgar.kettenis.dyndns.org> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-04/txt/msg00610.txt.bz2 On Sun, Apr 25, 2004 at 01:44:36PM +0200, Mark Kettenis wrote: > Anyway, can anybody shoot any holes in my new regexp? > - -re "type = (\[^\\r\\n\]*).*$gdb_prompt $" { > + -re "type = (.*)\r\n.*$gdb_prompt $" { Should work - but I'd do this instead, if it works: -re "type = (\[^\r\n\]*)\r\n$gdb_prompt $" No reason to use .* unnecessarily, and this prevents an error message from appearing after the ptype and not being caught. Our testsuite is very bad about that. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer