Re: [patch] Test scalar call/return/finish test - call-sc

[Mark Kettenis <kettenis@chello.nl>]

   Date: Sat, 24 Apr 2004 11:20:18 -0700
   From: Joel Brobecker <brobecker@gnat.com>

   > Joel, Jerome, AIX should have zero call-sc and structs failures (as 
   > there is for PPC/elf).
   > 
   > committed,
   > Andrew

   > 2004-04-23  Andrew Cagney  <cagney@redhat.com>
   > 
   > 	* gdb.base/call-sc.exp: New test of scalar call/return values.
   > 	* gdb.base/call-sc.c: Ditto.

   The following FAILs seem to be caused by a problem in the test itself rather
   than GDB.

	   FAIL: gdb.base/call-sc.exp: ptype foo; call-sc-tc cha
	   FAIL: gdb.base/call-sc.exp: ptype foo; call-sc-ts sho
	   FAIL: gdb.base/call-sc.exp: ptype foo; call-sc-ti i
	   FAIL: gdb.base/call-sc.exp: ptype foo; call-sc-tl lo
	   FAIL: gdb.base/call-sc.exp: ptype foo; call-sc-tll lo
	   FAIL: gdb.base/call-sc.exp: ptype foo; call-sc-tf float
	   FAIL: gdb.base/call-sc.exp: ptype foo; call-sc-td double
	   FAIL: gdb.base/call-sc.exp: ptype foo; call-sc-tld lo
	   FAIL: gdb.base/call-sc.exp: ptype foo; call-sc-te e

I agree.  Seems to be a problem with the regexp that Andrew used.
Note that the types are truncated at the letter `n' ot `r'.  The
attached patch works fixes these failures for me.

   The following ones seem to be bona fide problems:

	   FAIL: gdb.base/call-sc.exp: value foo returned; return call-sc-tc
	   FAIL: gdb.base/call-sc.exp: value foo returned; return call-sc-ts
	   ...
	   FAIL: gdb.base/call-sc.exp: p/c L; call call-sc-tf

I just checked in a patch that might fix these:

   http://sources.redhat.com/ml/gdb-patches/2004-04/msg00608.html

Anyway, can anybody shoot any holes in my new regexp?

Mark


Index: testsuite/ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* gdb.base/call-sc.exp (start_scalars_test): Fix regular
	expression that checks the return type.

Index: testsuite/gdb.base/call-sc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/call-sc.exp,v
retrieving revision 1.1
diff -u -p -r1.1 call-sc.exp
--- testsuite/gdb.base/call-sc.exp 23 Apr 2004 23:34:53 -0000 1.1
+++ testsuite/gdb.base/call-sc.exp 25 Apr 2004 11:39:19 -0000
@@ -115,7 +115,7 @@ proc start_scalars_test { type } {
     set test "ptype; ${testfile}"
     set foo_t "xxx"
     gdb_test_multiple "ptype ${type}" "${test}" {
-	-re "type = (\[^\\r\\n\]*).*$gdb_prompt $" {
+	-re "type = (.*)\r\n.*$gdb_prompt $" {
 	    set foo_t "$expect_out(1,string)"
 	    pass "$test (${foo_t})"
 	}