From: Joel Brobecker <brobecker@gnat.com>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] New dwarf2_attribute_true_p function in dwarf2read.c (take 2)
Date: Mon, 19 Apr 2004 17:09:00 -0000 [thread overview]
Message-ID: <20040419170932.GW22414@gnat.com> (raw)
In-Reply-To: <vt2zn98wjin.fsf@zenia.home>
> > 2004-04-16 Joel Brobecker <brobecker@gnat.com>
> >
> > * dwarf2read.c (dwarf2_attribute_true_p): New function.
> > (die_is_declaration): Use the function above. Add some comments.
> >
> > Tested on x86-linux, no regression.
> >
> > OK to apply?
>
> I'd like the comment for dwarf2_attribute_true_p to specifically say
> that it's meant for use with attributes with DW_FORM_flag values.
>
> (Trying to read more carefully this time...) Looks okay, otherwise.
I can add a comment, or if you prefer, I can change the name to make
it more explicit. Something like "form_flag_attribute_true_p", for
instance, or "dw_form_flag_attribute_true_p".
--
Joel
next prev parent reply other threads:[~2004-04-19 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:21 Joel Brobecker
2004-04-19 12:42 ` Jim Blandy
2004-04-19 17:09 ` Joel Brobecker [this message]
2004-04-19 17:18 ` Daniel Jacobowitz
2004-04-19 17:25 ` Joel Brobecker
2004-04-19 18:03 ` Jim Blandy
2004-04-19 18:13 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040419170932.GW22414@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox