Re: [RFA] New dwarf2_attribute_true_p function in dwarf2read.c (take 2)

[Jim Blandy <jimb@redhat.com>]

Joel Brobecker <brobecker@gnat.com> writes:

> Hello,
> 
> based on some comments made by Daniel in:
> 
>     http://sources.redhat.com/ml/gdb-patches/2004-04/msg00352.html
> 
> here is a new version of the patch. This time, I only check the flag
> for the DW_AT_declaration attribute. I also took this opportunity to
> rework a bit the comments. It sounds like better English to me, this
> time (any suggestion always welcome, btw).
> 
> 2004-04-16  Joel Brobecker  <brobecker@gnat.com>
> 
>         * dwarf2read.c (dwarf2_attribute_true_p): New function.
>         (die_is_declaration): Use the function above. Add some comments.
> 
> Tested on x86-linux, no regression.
> 
> OK to apply?

I'd like the comment for dwarf2_attribute_true_p to specifically say
that it's meant for use with attributes with DW_FORM_flag values.

(Trying to read more carefully this time...)  Looks okay, otherwise.