From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32349 invoked by alias); 19 Apr 2004 17:09:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32309 invoked from network); 19 Apr 2004 17:09:32 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 19 Apr 2004 17:09:32 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 5E9F347D63; Mon, 19 Apr 2004 10:09:32 -0700 (PDT) Date: Mon, 19 Apr 2004 17:09:00 -0000 From: Joel Brobecker To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] New dwarf2_attribute_true_p function in dwarf2read.c (take 2) Message-ID: <20040419170932.GW22414@gnat.com> References: <20040416212108.GJ22414@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i X-SW-Source: 2004-04/txt/msg00428.txt.bz2 > > 2004-04-16 Joel Brobecker > > > > * dwarf2read.c (dwarf2_attribute_true_p): New function. > > (die_is_declaration): Use the function above. Add some comments. > > > > Tested on x86-linux, no regression. > > > > OK to apply? > > I'd like the comment for dwarf2_attribute_true_p to specifically say > that it's meant for use with attributes with DW_FORM_flag values. > > (Trying to read more carefully this time...) Looks okay, otherwise. I can add a comment, or if you prefer, I can change the name to make it more explicit. Something like "form_flag_attribute_true_p", for instance, or "dw_form_flag_attribute_true_p". -- Joel