Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [patch/testsuite] Fix expected output for "help set follow-fork-mode"
Date: Sun, 04 Apr 2004 20:35:00 -0000	[thread overview]
Message-ID: <20040404203539.GG871@gnat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

There has been a recent change to infrun (made on 2004-01-13) that
removed the choice "ask" to the possible values for "follow-fork-mode".
The help text for that variable was then modified, but the test
verifying that the help for this command exists has not been modified.

This patch updates the expected output to match the new help text.

2004-04-04  Joel Brobecker  <brobecker@gnat.com>

        * gdb.base/foll-fork.exp: Update the expected output for
        "help set follow-fork-mode", to match a change that was made
        to the help of this variable on 2004-01-13.

Checked in as obvious.

I don't really know the purpose of this test. If, as the comment
suggests:

        # Verify that help is available for "set follow-fork-mode".

Then I would recommend that we don't need to check for the entire
help text word for word. I would simply check for the first line,
or even maybe just check that we receive something, anything, before
we get the prompt back.

(BTW, Is it really necessary to use send_gdb + gdb_expect? Could gdb_test
work just as well?)

-- 
Joel

[-- Attachment #2: foll-fork.exp.diff --]
[-- Type: text/plain, Size: 890 bytes --]

Index: foll-fork.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/foll-fork.exp,v
retrieving revision 1.2
diff -u -p -r1.2 foll-fork.exp
--- foll-fork.exp	6 Mar 2001 08:21:50 -0000	1.2
+++ foll-fork.exp	4 Apr 2004 20:24:51 -0000
@@ -280,8 +280,7 @@ proc do_fork_tests {} {
 A fork or vfork creates a new process.  follow-fork-mode can be:.*
 .*parent  - the original process is debugged after a fork.*
 .*child   - the new process is debugged after a fork.*
-.*ask     - the debugger will ask for one of the above choices.*
-For \"parent\" or \"child\", the unfollowed process will run free..*
+The unfollowed process will continue to run..*
 By default, the debugger will follow the parent process..*$gdb_prompt $"\
                       { pass "help set follow" }
       -re "$gdb_prompt $" { fail "help set follow" }

             reply	other threads:[~2004-04-04 20:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-04 20:35 Joel Brobecker [this message]
2004-04-04 21:12 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040404203539.GG871@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox