From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4137 invoked by alias); 4 Apr 2004 20:35:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4124 invoked from network); 4 Apr 2004 20:35:40 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 4 Apr 2004 20:35:40 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id A7F4147D62; Sun, 4 Apr 2004 13:35:39 -0700 (PDT) Date: Sun, 04 Apr 2004 20:35:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [patch/testsuite] Fix expected output for "help set follow-fork-mode" Message-ID: <20040404203539.GG871@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="RhUH2Ysw6aD5utA4" Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2004-04/txt/msg00116.txt.bz2 --RhUH2Ysw6aD5utA4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1079 There has been a recent change to infrun (made on 2004-01-13) that removed the choice "ask" to the possible values for "follow-fork-mode". The help text for that variable was then modified, but the test verifying that the help for this command exists has not been modified. This patch updates the expected output to match the new help text. 2004-04-04 Joel Brobecker * gdb.base/foll-fork.exp: Update the expected output for "help set follow-fork-mode", to match a change that was made to the help of this variable on 2004-01-13. Checked in as obvious. I don't really know the purpose of this test. If, as the comment suggests: # Verify that help is available for "set follow-fork-mode". Then I would recommend that we don't need to check for the entire help text word for word. I would simply check for the first line, or even maybe just check that we receive something, anything, before we get the prompt back. (BTW, Is it really necessary to use send_gdb + gdb_expect? Could gdb_test work just as well?) -- Joel --RhUH2Ysw6aD5utA4 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="foll-fork.exp.diff" Content-length: 890 Index: foll-fork.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/foll-fork.exp,v retrieving revision 1.2 diff -u -p -r1.2 foll-fork.exp --- foll-fork.exp 6 Mar 2001 08:21:50 -0000 1.2 +++ foll-fork.exp 4 Apr 2004 20:24:51 -0000 @@ -280,8 +280,7 @@ proc do_fork_tests {} { A fork or vfork creates a new process. follow-fork-mode can be:.* .*parent - the original process is debugged after a fork.* .*child - the new process is debugged after a fork.* -.*ask - the debugger will ask for one of the above choices.* -For \"parent\" or \"child\", the unfollowed process will run free..* +The unfollowed process will continue to run..* By default, the debugger will follow the parent process..*$gdb_prompt $"\ { pass "help set follow" } -re "$gdb_prompt $" { fail "help set follow" } --RhUH2Ysw6aD5utA4--