* [rfa/ppc] Make registers unsigned
2004-03-19 0:09 [rfa/ppc] Make registers unsigned Andrew Cagney
@ 2004-03-08 22:02 ` Andrew Cagney
2004-03-15 18:25 ` Andrew Cagney
2004-03-15 19:51 ` Kevin Buettner
2 siblings, 0 replies; 8+ messages in thread
From: Andrew Cagney @ 2004-03-08 22:02 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
Hello,
As far as I can tell PPC registers are unsigned. At present they are
signed and this leads to weird problems such as:
(gdb) x/i $sp
0xffff0000: ... error accessing memory at 0xffff0000
(gdb) x/i 0xffff0000
0xffff0000: sc
(gdb)
the attached changes this.
ok, 6.1?
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 781 bytes --]
2004-03-07 Andrew Cagney <cagney@redhat.com>
* rs6000-tdep.c (rs6000_register_virtual_type): Make registers
unsigned.
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.183
diff -u -r1.183 rs6000-tdep.c
--- rs6000-tdep.c 2 Mar 2004 02:20:25 -0000 1.183
+++ rs6000-tdep.c 8 Mar 2004 21:56:35 -0000
@@ -1862,12 +1862,12 @@
case 0:
return builtin_type_int0;
case 4:
- return builtin_type_int32;
+ return builtin_type_uint32;
case 8:
if (tdep->ppc_ev0_regnum <= n && n <= tdep->ppc_ev31_regnum)
return builtin_type_vec64;
else
- return builtin_type_int64;
+ return builtin_type_uint64;
break;
case 16:
return builtin_type_vec128;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [rfa/ppc] Make registers unsigned
2004-03-19 0:09 [rfa/ppc] Make registers unsigned Andrew Cagney
2004-03-08 22:02 ` Andrew Cagney
@ 2004-03-15 18:25 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-15 19:51 ` Kevin Buettner
2 siblings, 1 reply; 8+ messages in thread
From: Andrew Cagney @ 2004-03-15 18:25 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 5 bytes --]
ping
[-- Attachment #2: Attached Message --]
[-- Type: message/rfc822, Size: 4016 bytes --]
[-- Attachment #2.1.1: Type: text/plain, Size: 284 bytes --]
Hello,
As far as I can tell PPC registers are unsigned. At present they are
signed and this leads to weird problems such as:
(gdb) x/i $sp
0xffff0000: ... error accessing memory at 0xffff0000
(gdb) x/i 0xffff0000
0xffff0000: sc
(gdb)
the attached changes this.
ok, 6.1?
Andrew
[-- Attachment #2.1.2: diffs --]
[-- Type: text/plain, Size: 781 bytes --]
2004-03-07 Andrew Cagney <cagney@redhat.com>
* rs6000-tdep.c (rs6000_register_virtual_type): Make registers
unsigned.
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.183
diff -u -r1.183 rs6000-tdep.c
--- rs6000-tdep.c 2 Mar 2004 02:20:25 -0000 1.183
+++ rs6000-tdep.c 8 Mar 2004 21:56:35 -0000
@@ -1862,12 +1862,12 @@
case 0:
return builtin_type_int0;
case 4:
- return builtin_type_int32;
+ return builtin_type_uint32;
case 8:
if (tdep->ppc_ev0_regnum <= n && n <= tdep->ppc_ev31_regnum)
return builtin_type_vec64;
else
- return builtin_type_int64;
+ return builtin_type_uint64;
break;
case 16:
return builtin_type_vec128;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [rfa/ppc] Make registers unsigned
2004-03-19 0:09 [rfa/ppc] Make registers unsigned Andrew Cagney
2004-03-08 22:02 ` Andrew Cagney
2004-03-15 18:25 ` Andrew Cagney
@ 2004-03-15 19:51 ` Kevin Buettner
2004-03-19 0:09 ` Kevin Buettner
2004-03-19 0:09 ` Andrew Cagney
2 siblings, 2 replies; 8+ messages in thread
From: Kevin Buettner @ 2004-03-15 19:51 UTC (permalink / raw)
To: gdb-patches
On Mon, 08 Mar 2004 17:02:00 -0500
Andrew Cagney <cagney@gnu.org> wrote:
> 2004-03-07 Andrew Cagney <cagney@redhat.com>
>
> * rs6000-tdep.c (rs6000_register_virtual_type): Make registers
> unsigned.
Okay, for both mainline and 6.1.
Kevin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [rfa/ppc] Make registers unsigned
2004-03-19 0:09 ` Andrew Cagney
@ 2004-03-15 21:21 ` Andrew Cagney
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Cagney @ 2004-03-15 21:21 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
> On Mon, 08 Mar 2004 17:02:00 -0500
> Andrew Cagney <cagney@gnu.org> wrote:
>
>
>>> 2004-03-07 Andrew Cagney <cagney@redhat.com>
>>>
>>> * rs6000-tdep.c (rs6000_register_virtual_type): Make registers
>>> unsigned.
>
>
> Okay, for both mainline and 6.1.
I've checked it into the mainline, it's not absolutly needed for the branch.
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [rfa/ppc] Make registers unsigned
2004-03-15 18:25 ` Andrew Cagney
@ 2004-03-19 0:09 ` Andrew Cagney
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Cagney @ 2004-03-19 0:09 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 5 bytes --]
ping
[-- Attachment #2: Attached Message --]
[-- Type: message/rfc822, Size: 4016 bytes --]
[-- Attachment #2.1.1: Type: text/plain, Size: 284 bytes --]
Hello,
As far as I can tell PPC registers are unsigned. At present they are
signed and this leads to weird problems such as:
(gdb) x/i $sp
0xffff0000: ... error accessing memory at 0xffff0000
(gdb) x/i 0xffff0000
0xffff0000: sc
(gdb)
the attached changes this.
ok, 6.1?
Andrew
[-- Attachment #2.1.2: diffs --]
[-- Type: text/plain, Size: 781 bytes --]
2004-03-07 Andrew Cagney <cagney@redhat.com>
* rs6000-tdep.c (rs6000_register_virtual_type): Make registers
unsigned.
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.183
diff -u -r1.183 rs6000-tdep.c
--- rs6000-tdep.c 2 Mar 2004 02:20:25 -0000 1.183
+++ rs6000-tdep.c 8 Mar 2004 21:56:35 -0000
@@ -1862,12 +1862,12 @@
case 0:
return builtin_type_int0;
case 4:
- return builtin_type_int32;
+ return builtin_type_uint32;
case 8:
if (tdep->ppc_ev0_regnum <= n && n <= tdep->ppc_ev31_regnum)
return builtin_type_vec64;
else
- return builtin_type_int64;
+ return builtin_type_uint64;
break;
case 16:
return builtin_type_vec128;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [rfa/ppc] Make registers unsigned
2004-03-15 19:51 ` Kevin Buettner
@ 2004-03-19 0:09 ` Kevin Buettner
2004-03-19 0:09 ` Andrew Cagney
1 sibling, 0 replies; 8+ messages in thread
From: Kevin Buettner @ 2004-03-19 0:09 UTC (permalink / raw)
To: gdb-patches
On Mon, 08 Mar 2004 17:02:00 -0500
Andrew Cagney <cagney@gnu.org> wrote:
> 2004-03-07 Andrew Cagney <cagney@redhat.com>
>
> * rs6000-tdep.c (rs6000_register_virtual_type): Make registers
> unsigned.
Okay, for both mainline and 6.1.
Kevin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [rfa/ppc] Make registers unsigned
2004-03-15 19:51 ` Kevin Buettner
2004-03-19 0:09 ` Kevin Buettner
@ 2004-03-19 0:09 ` Andrew Cagney
2004-03-15 21:21 ` Andrew Cagney
1 sibling, 1 reply; 8+ messages in thread
From: Andrew Cagney @ 2004-03-19 0:09 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
> On Mon, 08 Mar 2004 17:02:00 -0500
> Andrew Cagney <cagney@gnu.org> wrote:
>
>
>>> 2004-03-07 Andrew Cagney <cagney@redhat.com>
>>>
>>> * rs6000-tdep.c (rs6000_register_virtual_type): Make registers
>>> unsigned.
>
>
> Okay, for both mainline and 6.1.
I've checked it into the mainline, it's not absolutly needed for the branch.
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* [rfa/ppc] Make registers unsigned
@ 2004-03-19 0:09 Andrew Cagney
2004-03-08 22:02 ` Andrew Cagney
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Andrew Cagney @ 2004-03-19 0:09 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
Hello,
As far as I can tell PPC registers are unsigned. At present they are
signed and this leads to weird problems such as:
(gdb) x/i $sp
0xffff0000: ... error accessing memory at 0xffff0000
(gdb) x/i 0xffff0000
0xffff0000: sc
(gdb)
the attached changes this.
ok, 6.1?
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 781 bytes --]
2004-03-07 Andrew Cagney <cagney@redhat.com>
* rs6000-tdep.c (rs6000_register_virtual_type): Make registers
unsigned.
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.183
diff -u -r1.183 rs6000-tdep.c
--- rs6000-tdep.c 2 Mar 2004 02:20:25 -0000 1.183
+++ rs6000-tdep.c 8 Mar 2004 21:56:35 -0000
@@ -1862,12 +1862,12 @@
case 0:
return builtin_type_int0;
case 4:
- return builtin_type_int32;
+ return builtin_type_uint32;
case 8:
if (tdep->ppc_ev0_regnum <= n && n <= tdep->ppc_ev31_regnum)
return builtin_type_vec64;
else
- return builtin_type_int64;
+ return builtin_type_uint64;
break;
case 16:
return builtin_type_vec128;
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2004-03-15 21:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-19 0:09 [rfa/ppc] Make registers unsigned Andrew Cagney
2004-03-08 22:02 ` Andrew Cagney
2004-03-15 18:25 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-15 19:51 ` Kevin Buettner
2004-03-19 0:09 ` Kevin Buettner
2004-03-19 0:09 ` Andrew Cagney
2004-03-15 21:21 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox