From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8996 invoked by alias); 15 Mar 2004 18:25:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8967 invoked from network); 15 Mar 2004 18:25:39 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 15 Mar 2004 18:25:39 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4C7A62B92; Mon, 15 Mar 2004 13:25:39 -0500 (EST) Message-ID: <4055F523.1000902@gnu.org> Date: Mon, 15 Mar 2004 18:25:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [rfa/ppc] Make registers unsigned References: <404CED58.4010205@gnu.org> In-Reply-To: <404CED58.4010205@gnu.org> Content-Type: multipart/mixed; boundary="------------030801060908090403040504" X-SW-Source: 2004-03.o/txt/msg00317.txt This is a multi-part message in MIME format. --------------030801060908090403040504 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 5 ping --------------030801060908090403040504 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="Attached Message" Content-length: 3976 Return-Path: Delivered-To: cagney@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1783D2B92 for ; Mon, 8 Mar 2004 17:07:26 -0500 (EST) Envelope-to: cagney@gnu.org Delivery-date: Mon, 08 Mar 2004 17:01:07 -0500 Received: from fencepost.gnu.org by localhost with IMAP (fetchmail-6.2.4) for cagney@localhost (single-drop); Mon, 08 Mar 2004 17:07:26 -0500 (EST) Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.24) id 1B0So7-0004KX-GE for cagney@gnu.org; Mon, 08 Mar 2004 17:01:07 -0500 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B0SqH-00085H-Qk for cagney@gnu.org; Mon, 08 Mar 2004 17:03:42 -0500 Received: from [67.72.78.213] (helo=sources.redhat.com) by monty-python.gnu.org with smtp (Exim 4.30) id 1B0SqG-00084s-8B for cagney@gnu.org; Mon, 08 Mar 2004 17:03:20 -0500 Received: (qmail 16119 invoked by alias); 8 Mar 2004 22:02:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Delivered-To: mailing list gdb-patches@sources.redhat.com Received: (qmail 16059 invoked from network); 8 Mar 2004 22:02:06 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 8 Mar 2004 22:02:06 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5F6232B92; Mon, 8 Mar 2004 17:02:00 -0500 (EST) Message-ID: <404CED58.4010205@gnu.org> Date: Mon, 08 Mar 2004 17:02:00 -0500 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [rfa/ppc] Make registers unsigned Content-Type: multipart/mixed; boundary="------------060502030203060502050409" X-Spam-Status: No, hits=-0.5 required=5.0 tests=PATCH_UNIFIED_DIFF,USER_AGENT_MOZILLA_UA version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) This is a multi-part message in MIME format. --------------060502030203060502050409 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 284 Hello, As far as I can tell PPC registers are unsigned. At present they are signed and this leads to weird problems such as: (gdb) x/i $sp 0xffff0000: ... error accessing memory at 0xffff0000 (gdb) x/i 0xffff0000 0xffff0000: sc (gdb) the attached changes this. ok, 6.1? Andrew --------------060502030203060502050409 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 781 2004-03-07 Andrew Cagney * rs6000-tdep.c (rs6000_register_virtual_type): Make registers unsigned. Index: rs6000-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v retrieving revision 1.183 diff -u -r1.183 rs6000-tdep.c --- rs6000-tdep.c 2 Mar 2004 02:20:25 -0000 1.183 +++ rs6000-tdep.c 8 Mar 2004 21:56:35 -0000 @@ -1862,12 +1862,12 @@ case 0: return builtin_type_int0; case 4: - return builtin_type_int32; + return builtin_type_uint32; case 8: if (tdep->ppc_ev0_regnum <= n && n <= tdep->ppc_ev31_regnum) return builtin_type_vec64; else - return builtin_type_int64; + return builtin_type_uint64; break; case 16: return builtin_type_vec128; --------------060502030203060502050409-- --------------030801060908090403040504-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8996 invoked by alias); 15 Mar 2004 18:25:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8967 invoked from network); 15 Mar 2004 18:25:39 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 15 Mar 2004 18:25:39 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4C7A62B92; Mon, 15 Mar 2004 13:25:39 -0500 (EST) Message-ID: <4055F523.1000902@gnu.org> Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [rfa/ppc] Make registers unsigned References: <404CED58.4010205@gnu.org> In-Reply-To: <404CED58.4010205@gnu.org> Content-Type: multipart/mixed; boundary="------------030801060908090403040504" X-SW-Source: 2004-03/txt/msg00317.txt.bz2 Message-ID: <20040319000900.oyYX3SUWNGVQxbfyvRvoaAO9Yo1I2H2lZ1D22-NG4g8@z> This is a multi-part message in MIME format. --------------030801060908090403040504 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 5 ping --------------030801060908090403040504 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="Attached Message" Content-length: 3976 Return-Path: Delivered-To: cagney@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1783D2B92 for ; Mon, 8 Mar 2004 17:07:26 -0500 (EST) Envelope-to: cagney@gnu.org Delivery-date: Mon, 08 Mar 2004 17:01:07 -0500 Received: from fencepost.gnu.org by localhost with IMAP (fetchmail-6.2.4) for cagney@localhost (single-drop); Mon, 08 Mar 2004 17:07:26 -0500 (EST) Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.24) id 1B0So7-0004KX-GE for cagney@gnu.org; Mon, 08 Mar 2004 17:01:07 -0500 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B0SqH-00085H-Qk for cagney@gnu.org; Mon, 08 Mar 2004 17:03:42 -0500 Received: from [67.72.78.213] (helo=sources.redhat.com) by monty-python.gnu.org with smtp (Exim 4.30) id 1B0SqG-00084s-8B for cagney@gnu.org; Mon, 08 Mar 2004 17:03:20 -0500 Received: (qmail 16119 invoked by alias); 8 Mar 2004 22:02:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Delivered-To: mailing list gdb-patches@sources.redhat.com Received: (qmail 16059 invoked from network); 8 Mar 2004 22:02:06 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 8 Mar 2004 22:02:06 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5F6232B92; Mon, 8 Mar 2004 17:02:00 -0500 (EST) Message-ID: <404CED58.4010205@gnu.org> Date: Mon, 08 Mar 2004 17:02:00 -0500 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [rfa/ppc] Make registers unsigned Content-Type: multipart/mixed; boundary="------------060502030203060502050409" X-Spam-Status: No, hits=-0.5 required=5.0 tests=PATCH_UNIFIED_DIFF,USER_AGENT_MOZILLA_UA version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) This is a multi-part message in MIME format. --------------060502030203060502050409 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 284 Hello, As far as I can tell PPC registers are unsigned. At present they are signed and this leads to weird problems such as: (gdb) x/i $sp 0xffff0000: ... error accessing memory at 0xffff0000 (gdb) x/i 0xffff0000 0xffff0000: sc (gdb) the attached changes this. ok, 6.1? Andrew --------------060502030203060502050409 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 781 2004-03-07 Andrew Cagney * rs6000-tdep.c (rs6000_register_virtual_type): Make registers unsigned. Index: rs6000-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v retrieving revision 1.183 diff -u -r1.183 rs6000-tdep.c --- rs6000-tdep.c 2 Mar 2004 02:20:25 -0000 1.183 +++ rs6000-tdep.c 8 Mar 2004 21:56:35 -0000 @@ -1862,12 +1862,12 @@ case 0: return builtin_type_int0; case 4: - return builtin_type_int32; + return builtin_type_uint32; case 8: if (tdep->ppc_ev0_regnum <= n && n <= tdep->ppc_ev31_regnum) return builtin_type_vec64; else - return builtin_type_int64; + return builtin_type_uint64; break; case 16: return builtin_type_vec128; --------------060502030203060502050409-- --------------030801060908090403040504--