Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Re: [rfa/testsuite] gdb1250.exp: Handle pending breakpoint in shared library
@ 2004-03-11  1:55 Michael Elizabeth Chastain
  2004-03-19  0:09 ` Michael Elizabeth Chastain
  2004-03-23 23:06 ` Andrew Cagney
  0 siblings, 2 replies; 9+ messages in thread
From: Michael Elizabeth Chastain @ 2004-03-11  1:55 UTC (permalink / raw)
  To: drow, mec.gnu; +Cc: gdb-patches

drow> I'd rather not.  You were happy with my last patch to add runto
drow> {allow-pending}, yes?  I could just commit that.

I'm happy with your patch, but I haven't seen anything from
Fernando N or Mark S, and those are the only people who can
approve patches in testsuite/lib.

That's why I just capitulated and made gdb1250.exp look like
pending.exp and langs.exp.

Michael C


^ permalink raw reply	[flat|nested] 9+ messages in thread
* [rfa/testsuite] gdb1250.exp: Handle pending breakpoint in shared library
@ 2004-03-19  0:09 Michael Elizabeth Chastain
  2004-03-11  1:22 ` Michael Elizabeth Chastain
  2004-03-11  1:52 ` Daniel Jacobowitz
  0 siblings, 2 replies; 9+ messages in thread
From: Michael Elizabeth Chastain @ 2004-03-19  0:09 UTC (permalink / raw)
  To: gdb-patches

Here is another attempt to fix gdb1250.exp so that it works with
the new 'pending breakpoint' feature.

I would like to get this fixed so that I can take it off my list
of regressions for binutils binutils-2_15-branch versus binutils 2.14.

Tested on: native i686-pc-linux-gnu, gcc 2.95.3 3.3.3 HEAD,
binutils 2.14 binutils-2_15-branch HEAD, dwarf-2 stabs+.

I'm not sure that "run" is the right command to issue to start
running the inferior.  If it's not the right command, I would be
happy to change it.

Okay to commit?

Michael C

2004-03-10  Michael Chastain  <mec.gnu@mindspring.com>

	* gdb.base/gdb1250.exp: Accommodate a pending breakpoint in
	a shared library.

Index: gdb1250.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gdb1250.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 gdb1250.exp
*** gdb1250.exp	15 Jul 2003 16:28:21 -0000	1.1
--- gdb1250.exp	11 Mar 2004 01:17:07 -0000
***************
*** 1,4 ****
! # Copyright 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 2003, 2004 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
*************** gdb_start
*** 42,51 ****
  gdb_reinitialize_dir $srcdir/$subdir
  gdb_load ${binfile}
  
! if ![runto abort] then {
!     perror "couldn't run to breakpoint"
!     continue
  }
  
  # See http://sources.redhat.com/gdb/bugs/1250
  #
--- 42,62 ----
  gdb_reinitialize_dir $srcdir/$subdir
  gdb_load ${binfile}
  
! # Run on 'abort'.  'abort' is special because gcc knows that it is a
! # no-return function, so gcc does a special optimization in every
! # caller of 'abort'.
! 
! set name "break abort"
! gdb_test_multiple "break abort" $name {
!     -re "Function \"abort\" not defined\.\r\nMake breakpoint pending on future shared library load\\? \\(y or \\\[n\\\]\\) $" {
! 	gdb_test "y" "" $name
!     }
!     -re "Breakpoint $decimal at .*\r\n$gdb_prompt $" {
! 	pass $name
!     }
  }
+ 
+ gdb_test "run" "Breakpoint $decimal.*abort.*" "run to abort"
  
  # See http://sources.redhat.com/gdb/bugs/1250
  #


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [rfa/testsuite] gdb1250.exp: Handle pending breakpoint in shared library
@ 2004-03-24 18:25 Michael Elizabeth Chastain
  2004-03-24 18:42 ` Daniel Jacobowitz
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Elizabeth Chastain @ 2004-03-24 18:25 UTC (permalink / raw)
  To: cagney, mec.gnu; +Cc: drow, gdb-patches

> Michael, can you commit "that"?

<busy signal>

I have my hands full with something else so I can't get to very much
gdb stuff before Friday evening.

Michael C


^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2004-03-24 18:42 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-11  1:55 [rfa/testsuite] gdb1250.exp: Handle pending breakpoint in shared library Michael Elizabeth Chastain
2004-03-19  0:09 ` Michael Elizabeth Chastain
2004-03-23 23:06 ` Andrew Cagney
2004-03-19  0:09 Michael Elizabeth Chastain
2004-03-11  1:22 ` Michael Elizabeth Chastain
2004-03-11  1:52 ` Daniel Jacobowitz
2004-03-19  0:09   ` Daniel Jacobowitz
2004-03-24 18:25 Michael Elizabeth Chastain
2004-03-24 18:42 ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox