Re: [patch/rfc,6.1?] Use right frame ID in step_over_function

[Andrew Cagney <cagney@gnu.org>]

> Hello,
> 
> This goes into the "how did it ever work" category.  The idea of step_over_function is that it:
> 
> - finds the caller's resume address
> - finds the caller's frame ID
> 
> and then sets a breakpoint for that caller instance of the function. The current code:
> 
> - finds the caller's resume address
> - finds the _callee_ frame ID
> 
> and then uses that to set the breakpoint.  Now that is plain weird!  It only works because either:
> 
> - the step_frame_id patches up the bug
> 
> - the values match as GDB is using the inner-most, rather than outer-most frame address as part of the frame ID
> 
> The bug apepars when trying to step over nested shared library non-debug info functions (making sense?).
> 
> I'll follow this up after 6.1 branch is in place.
> 
> Its pretty heavy a change to apply to that branch and this late. However, like Joel's related patch, I suspect it will be needed :-/

I've checked this into the mainline.  For the moment I think I'll drop 
the idea of committing it to the branch.

Andrew



> 	* infrun.c (step_over_function): When non-legacy code, and no
> 	step_frame_id, use the unwinder to get the caller's frame ID.
>