Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc,6.1?] Use right frame ID in step_over_function
Date: Sun, 29 Feb 2004 17:18:00 -0000	[thread overview]
Message-ID: <20040229171801.GK15749@nevyn.them.org> (raw)
In-Reply-To: <40416BAF.1020308@gnu.org>

On Sat, Feb 28, 2004 at 11:33:51PM -0500, Andrew Cagney wrote:
> Hello,
> 
> This goes into the "how did it ever work" category.  The idea of 
> step_over_function is that it:
> 
> - finds the caller's resume address
> - finds the caller's frame ID
> 
> and then sets a breakpoint for that caller instance of the function. 
> The current code:
> 
> - finds the caller's resume address
> - finds the _callee_ frame ID
> 
> and then uses that to set the breakpoint.  Now that is plain weird!  It 
> only works because either:
> 
> - the step_frame_id patches up the bug
> 
> - the values match as GDB is using the inner-most, rather than 
> outer-most frame address as part of the frame ID
> 
> The bug apepars when trying to step over nested shared library non-debug 
> info functions (making sense?).

No, not really.  Could you give us a testcase?  What platform have you
seen this behavior on?

> I'll follow this up after 6.1 branch is in place.
> 
> Its pretty heavy a change to apply to that branch and this late. 
> However, like Joel's related patch, I suspect it will be needed :-/
> 
> Andrew
> 
> PS: Why do I have this feeling of dejavu?

Because we discussed this problem in July 2003 and neither of us had
time to come back to the issue?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-02-29 17:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-29  4:33 Andrew Cagney
2004-02-29 17:18 ` Daniel Jacobowitz [this message]
2004-03-19  0:09   ` Andrew Cagney
2004-03-01  1:24     ` Andrew Cagney
2004-03-05 23:02 ` Andrew Cagney
2004-03-05 23:39   ` Daniel Jacobowitz
2004-03-06  0:08     ` Andrew Cagney
2004-03-19  0:09       ` Andrew Cagney
2004-03-19  0:09     ` Daniel Jacobowitz
2004-03-19  0:09   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040229171801.GK15749@nevyn.them.org \
    --to=drow@false.org \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox