Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@elta.co.il>
To: Jason Molenda <jmolenda@apple.com>
Cc: cagney@gnu.org, gdb-patches@sources.redhat.com
Subject: Re: RFC patch mi-cmds.c table format (pedantic)
Date: Thu, 18 Mar 2004 05:53:00 -0000	[thread overview]
Message-ID: <uptba7l9n.fsf@elta.co.il> (raw)
Message-ID: <20040318055300.j6VS96cWSdLBep3sVJ9by0PsO-vIItbFJJtEfCtRmW4@z> (raw)
In-Reply-To: <6994FFF8-786D-11D8-9229-000393D457E2@apple.com> (message from Jason Molenda on Wed, 17 Mar 2004 15:47:12 -0800)

> From: Jason Molenda <jmolenda@apple.com>
> Date: Wed, 17 Mar 2004 15:47:12 -0800
> 
> As you can see here, the use of 0 vs NULL is inconsistent, and the=20
> spacing on the close parens on the last arg is inconsistent.  The=20
> implied initialization of 0 is also used in many places.  All of this=20
> is valid, but it could be a bit more consistent.  So instead of
> 
> -  { "break-insert", { NULL, 0 }, 0, mi_cmd_break_insert},
> +  { "break-insert", { NULL, 0 }, NULL, mi_cmd_break_insert},
> 
> -  { "exec-step", { NULL, 0 }, mi_cmd_exec_step},
> +  { "exec-step", { NULL, 0 }, mi_cmd_exec_step, NULL},
> 
> -  { NULL, }
> +  { NULL, { NULL, 0 }, NULL, NULL}

Don't these changes require changes to the GDB/MI documentation in
gdb.texinfo?  IIRC, there are examples there to what each command
outputs.


  parent reply	other threads:[~2004-03-18  5:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-19  0:09 Jason Molenda
2004-03-17 23:47 ` Jason Molenda
2004-03-19  0:09 ` Andrew Cagney
2004-03-19  0:34   ` Jason Molenda
2004-03-19 15:12     ` Andrew Cagney
2004-03-19  0:09 ` Eli Zaretskii [this message]
2004-03-18  5:53   ` Eli Zaretskii
2004-03-19  0:09   ` Jason Molenda
2004-03-18 19:26     ` Jason Molenda
2004-03-19 14:36     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uptba7l9n.fsf@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jmolenda@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox