Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
To: carlton@kealia.com, gdb-patches@sources.redhat.com
Subject: [patch/testsuite/cp] templates.exp: accept "Foo<(char*)&string)"
Date: Fri, 19 Mar 2004 00:09:00 -0000	[thread overview]
Message-ID: <20040312163923.B76FD4B104@berman.michael-chastain.com> (raw)

This patch improves templates.exp to accept this:

  (gdb) ptype quxint
  type = class Qux<int, (char *)(&string)> ...

This happens with gcc gcc-3_4-branch, gcc HEAD, and gcc
tree-ssa-200206129-branch with stabs+.

I tested this on:

  native i686-pc-linux-gnu
  gcc 2.95.3, 3.2-7-rh, 3.3.3, gcc-3_3-branch, gcc-3_4-branch, HEAD, tree-ssa-20020619-branch
  dwarf-2, stabs+

We had some discussion about this earlier and drow and carlton are
okay with accepting the "(char *)(&string)" form.

I am committing this to gdb HEAD now.  I am going to test it
on the branch and commit to the branch as well.

Michael C

2004-03-12  Michael Chastain  <mec.gnu@mindspring.com>

	* gdb.cp/templates.exp: Accept more template types.

Index: templates.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/templates.exp,v
retrieving revision 1.9
diff -c -3 -p -r1.9 templates.exp
*** templates.exp	11 Feb 2004 14:01:25 -0000	1.9
--- templates.exp	12 Mar 2004 16:34:01 -0000
*************** send_gdb "ptype quxint\n"   
*** 455,460 ****
--- 455,461 ----
  gdb_expect {   
     -re "type = class Qux<int, ?&string> \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*.*int qux\\(int, int\\);\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" }
     -re "type = class Qux<int, ?&string> \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" }
+    -re "type = class Qux<int, ?\\(char ?\\*\\)\\(&string\\)> \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" }
     -re "type = class Qux<int, ?&\\(string\\)> \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" {
         kfail "gdb/1512" "ptype quxint"
     }


WARNING: multiple messages have this Message-ID
From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
To: carlton@kealia.com, gdb-patches@sources.redhat.com
Subject: [patch/testsuite/cp] templates.exp: accept "Foo<(char*)&string)"
Date: Fri, 12 Mar 2004 16:39:00 -0000	[thread overview]
Message-ID: <20040312163923.B76FD4B104@berman.michael-chastain.com> (raw)
Message-ID: <20040312163900.tx4TOyIYqJg0xe6i5fKslIKUJa9iVHZ1zD0zfnxzSic@z> (raw)

This patch improves templates.exp to accept this:

  (gdb) ptype quxint
  type = class Qux<int, (char *)(&string)> ...

This happens with gcc gcc-3_4-branch, gcc HEAD, and gcc
tree-ssa-200206129-branch with stabs+.

I tested this on:

  native i686-pc-linux-gnu
  gcc 2.95.3, 3.2-7-rh, 3.3.3, gcc-3_3-branch, gcc-3_4-branch, HEAD, tree-ssa-20020619-branch
  dwarf-2, stabs+

We had some discussion about this earlier and drow and carlton are
okay with accepting the "(char *)(&string)" form.

I am committing this to gdb HEAD now.  I am going to test it
on the branch and commit to the branch as well.

Michael C

2004-03-12  Michael Chastain  <mec.gnu@mindspring.com>

	* gdb.cp/templates.exp: Accept more template types.

Index: templates.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/templates.exp,v
retrieving revision 1.9
diff -c -3 -p -r1.9 templates.exp
*** templates.exp	11 Feb 2004 14:01:25 -0000	1.9
--- templates.exp	12 Mar 2004 16:34:01 -0000
*************** send_gdb "ptype quxint\n"   
*** 455,460 ****
--- 455,461 ----
  gdb_expect {   
     -re "type = class Qux<int, ?&string> \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*.*int qux\\(int, int\\);\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" }
     -re "type = class Qux<int, ?&string> \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" }
+    -re "type = class Qux<int, ?\\(char ?\\*\\)\\(&string\\)> \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" }
     -re "type = class Qux<int, ?&\\(string\\)> \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" {
         kfail "gdb/1512" "ptype quxint"
     }


             reply	other threads:[~2004-03-12 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-19  0:09 Michael Elizabeth Chastain [this message]
2004-03-12 16:39 ` Michael Elizabeth Chastain
  -- strict thread matches above, loose matches on Subject: below --
2004-03-19  0:09 Michael Elizabeth Chastain
2004-03-12 16:53 ` Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040312163923.B76FD4B104@berman.michael-chastain.com \
    --to=mec.gnu@mindspring.com \
    --cc=carlton@kealia.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox