From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30927 invoked by alias); 12 Mar 2004 16:39:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30898 invoked from network); 12 Mar 2004 16:39:18 -0000 Received: from unknown (HELO smtp6.mindspring.com) (207.69.200.110) by sources.redhat.com with SMTP; 12 Mar 2004 16:39:18 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by smtp6.mindspring.com with esmtp (Exim 3.33 #1) id 1B1pgm-0005eD-00; Fri, 12 Mar 2004 11:39:12 -0500 Received: by berman.michael-chastain.com (Postfix, from userid 502) id B76FD4B104; Fri, 12 Mar 2004 11:39:23 -0500 (EST) To: carlton@kealia.com, gdb-patches@sources.redhat.com Subject: [patch/testsuite/cp] templates.exp: accept "Foo<(char*)&string)" Message-Id: <20040312163923.B76FD4B104@berman.michael-chastain.com> Date: Fri, 19 Mar 2004 00:09:00 -0000 From: mec.gnu@mindspring.com (Michael Elizabeth Chastain) X-SW-Source: 2004-03/txt/msg00284.txt.bz2 This patch improves templates.exp to accept this: (gdb) ptype quxint type = class Qux ... This happens with gcc gcc-3_4-branch, gcc HEAD, and gcc tree-ssa-200206129-branch with stabs+. I tested this on: native i686-pc-linux-gnu gcc 2.95.3, 3.2-7-rh, 3.3.3, gcc-3_3-branch, gcc-3_4-branch, HEAD, tree-ssa-20020619-branch dwarf-2, stabs+ We had some discussion about this earlier and drow and carlton are okay with accepting the "(char *)(&string)" form. I am committing this to gdb HEAD now. I am going to test it on the branch and commit to the branch as well. Michael C 2004-03-12 Michael Chastain * gdb.cp/templates.exp: Accept more template types. Index: templates.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/templates.exp,v retrieving revision 1.9 diff -c -3 -p -r1.9 templates.exp *** templates.exp 11 Feb 2004 14:01:25 -0000 1.9 --- templates.exp 12 Mar 2004 16:34:01 -0000 *************** send_gdb "ptype quxint\n" *** 455,460 **** --- 455,461 ---- gdb_expect { -re "type = class Qux \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*.*int qux\\(int, int\\);\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" } -re "type = class Qux \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" } + -re "type = class Qux \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" } -re "type = class Qux \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { kfail "gdb/1512" "ptype quxint" } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30927 invoked by alias); 12 Mar 2004 16:39:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30898 invoked from network); 12 Mar 2004 16:39:18 -0000 Received: from unknown (HELO smtp6.mindspring.com) (207.69.200.110) by sources.redhat.com with SMTP; 12 Mar 2004 16:39:18 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by smtp6.mindspring.com with esmtp (Exim 3.33 #1) id 1B1pgm-0005eD-00; Fri, 12 Mar 2004 11:39:12 -0500 Received: by berman.michael-chastain.com (Postfix, from userid 502) id B76FD4B104; Fri, 12 Mar 2004 11:39:23 -0500 (EST) To: carlton@kealia.com, gdb-patches@sources.redhat.com Subject: [patch/testsuite/cp] templates.exp: accept "Foo<(char*)&string)" Message-ID: <20040312163923.B76FD4B104@berman.michael-chastain.com> Date: Fri, 12 Mar 2004 16:39:00 -0000 From: mec.gnu@mindspring.com (Michael Elizabeth Chastain) X-SW-Source: 2004-03.o/txt/msg00284.txt Message-ID: <20040312163900.tx4TOyIYqJg0xe6i5fKslIKUJa9iVHZ1zD0zfnxzSic@z> This patch improves templates.exp to accept this: (gdb) ptype quxint type = class Qux ... This happens with gcc gcc-3_4-branch, gcc HEAD, and gcc tree-ssa-200206129-branch with stabs+. I tested this on: native i686-pc-linux-gnu gcc 2.95.3, 3.2-7-rh, 3.3.3, gcc-3_3-branch, gcc-3_4-branch, HEAD, tree-ssa-20020619-branch dwarf-2, stabs+ We had some discussion about this earlier and drow and carlton are okay with accepting the "(char *)(&string)" form. I am committing this to gdb HEAD now. I am going to test it on the branch and commit to the branch as well. Michael C 2004-03-12 Michael Chastain * gdb.cp/templates.exp: Accept more template types. Index: templates.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/templates.exp,v retrieving revision 1.9 diff -c -3 -p -r1.9 templates.exp *** templates.exp 11 Feb 2004 14:01:25 -0000 1.9 --- templates.exp 12 Mar 2004 16:34:01 -0000 *************** send_gdb "ptype quxint\n" *** 455,460 **** --- 455,461 ---- gdb_expect { -re "type = class Qux \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*.*int qux\\(int, int\\);\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" } -re "type = class Qux \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" } + -re "type = class Qux \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { pass "ptype quxint" } -re "type = class Qux \\{\r\n\[ \t\]*public:\r\n\[ \t\]*int x;\r\n\[ \t\]*int t;\r\n\r\n\[ \t\]*int qux\\(int, int\\);.*\r\n\\}\r\n$gdb_prompt $" { kfail "gdb/1512" "ptype quxint" }