Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [ob(ish)/committed] Fix SEGV in hppa_frame_cache
Date: Wed, 10 Mar 2004 20:09:00 -0000	[thread overview]
Message-ID: <20040310200913.GH1154@gnat.com> (raw)
In-Reply-To: <40491E6B.1000900@gnu.org>

> >Unfortunately, that return causes the return value to be undefined.
> >And we later crash while trying to dereference this undefined value
> >in hppa_frame_this_id().
> >
> >So I fixed it with the attached patch. This fixed 8 tests.
> >I didn't commit it to the 6.1 branch yet, as I wanted to wait for
> >Andrew's comments first. Don't want to disturb the branch too much.
> 
> For HP/UX, I think we'll be doing frequent pull-ups - this will be just 
> the first of many bugs :-(  Definitly go ahead.

Sorry for the delay. I just committed this change on the branch.

2004-03-10  J. Brobecker  <brobecker@gnat.com>

        * hppa-tdep.c (hppa_frame_cache): Avoid undefined return value.

Thanks,
-- 
Joel

PS: I am unfortunately a bit busy at the moment, but I'd like to reread
your comments again, and send mine if needed. So I'm keeping your message
in my inbox...


WARNING: multiple messages have this Message-ID

From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [ob(ish)/committed] Fix SEGV in hppa_frame_cache
Date: Fri, 19 Mar 2004 00:09:00 -0000	[thread overview]
Message-ID: <20040310200913.GH1154@gnat.com> (raw)
Message-ID: <20040319000900.zub6diM-fUIFH3AJCbB0ALdojL5ABtlKC9Zo57Mp7vg@z> (raw)
In-Reply-To: <40491E6B.1000900@gnu.org>

> >Unfortunately, that return causes the return value to be undefined.
> >And we later crash while trying to dereference this undefined value
> >in hppa_frame_this_id().
> >
> >So I fixed it with the attached patch. This fixed 8 tests.
> >I didn't commit it to the 6.1 branch yet, as I wanted to wait for
> >Andrew's comments first. Don't want to disturb the branch too much.
> 
> For HP/UX, I think we'll be doing frequent pull-ups - this will be just 
> the first of many bugs :-(  Definitly go ahead.

Sorry for the delay. I just committed this change on the branch.

2004-03-10  J. Brobecker  <brobecker@gnat.com>

        * hppa-tdep.c (hppa_frame_cache): Avoid undefined return value.

Thanks,
-- 
Joel

PS: I am unfortunately a bit busy at the moment, but I'd like to reread
your comments again, and send mine if needed. So I'm keeping your message
in my inbox...


  parent reply	other threads:[~2004-03-10 20:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-05  5:05 Joel Brobecker
2004-03-19  0:09 ` Andrew Cagney
2004-03-06  0:42   ` Andrew Cagney
2004-03-10 20:09   ` Joel Brobecker [this message]
2004-03-19  0:09     ` Joel Brobecker
2004-03-19  0:09 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040310200913.GH1154@gnat.com \
    --to=brobecker@gnat.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox