From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29753 invoked by alias); 10 Mar 2004 20:09:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29745 invoked from network); 10 Mar 2004 20:09:08 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 10 Mar 2004 20:09:08 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 450C347D62; Wed, 10 Mar 2004 12:09:13 -0800 (PST) Date: Wed, 10 Mar 2004 20:09:00 -0000 From: Joel Brobecker To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [ob(ish)/committed] Fix SEGV in hppa_frame_cache Message-ID: <20040310200913.GH1154@gnat.com> References: <20040305050546.GC1226@gnat.com> <40491E6B.1000900@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40491E6B.1000900@gnu.org> User-Agent: Mutt/1.4i X-SW-Source: 2004-03.o/txt/msg00249.txt > >Unfortunately, that return causes the return value to be undefined. > >And we later crash while trying to dereference this undefined value > >in hppa_frame_this_id(). > > > >So I fixed it with the attached patch. This fixed 8 tests. > >I didn't commit it to the 6.1 branch yet, as I wanted to wait for > >Andrew's comments first. Don't want to disturb the branch too much. > > For HP/UX, I think we'll be doing frequent pull-ups - this will be just > the first of many bugs :-( Definitly go ahead. Sorry for the delay. I just committed this change on the branch. 2004-03-10 J. Brobecker * hppa-tdep.c (hppa_frame_cache): Avoid undefined return value. Thanks, -- Joel PS: I am unfortunately a bit busy at the moment, but I'd like to reread your comments again, and send mine if needed. So I'm keeping your message in my inbox... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29753 invoked by alias); 10 Mar 2004 20:09:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29745 invoked from network); 10 Mar 2004 20:09:08 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 10 Mar 2004 20:09:08 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 450C347D62; Wed, 10 Mar 2004 12:09:13 -0800 (PST) Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Joel Brobecker To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [ob(ish)/committed] Fix SEGV in hppa_frame_cache Message-ID: <20040310200913.GH1154@gnat.com> References: <20040305050546.GC1226@gnat.com> <40491E6B.1000900@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40491E6B.1000900@gnu.org> User-Agent: Mutt/1.4i X-SW-Source: 2004-03/txt/msg00249.txt.bz2 Message-ID: <20040319000900.zub6diM-fUIFH3AJCbB0ALdojL5ABtlKC9Zo57Mp7vg@z> > >Unfortunately, that return causes the return value to be undefined. > >And we later crash while trying to dereference this undefined value > >in hppa_frame_this_id(). > > > >So I fixed it with the attached patch. This fixed 8 tests. > >I didn't commit it to the 6.1 branch yet, as I wanted to wait for > >Andrew's comments first. Don't want to disturb the branch too much. > > For HP/UX, I think we'll be doing frequent pull-ups - this will be just > the first of many bugs :-( Definitly go ahead. Sorry for the delay. I just committed this change on the branch. 2004-03-10 J. Brobecker * hppa-tdep.c (hppa_frame_cache): Avoid undefined return value. Thanks, -- Joel PS: I am unfortunately a bit busy at the moment, but I'd like to reread your comments again, and send mine if needed. So I'm keeping your message in my inbox...