[patch] Fix chng-syms.exp for remote stubs

[patch] Fix chng-syms.exp for remote stubs

[Daniel Jacobowitz]

gdb_continue_to_end, used earlier in this file, may set a breakpoint at
exit.  We can't easily delete that breakpoint, because we're testing for
another breakpoint's behaviour.  The easiest fix is to allow the breakpoint
at exit to count as a pass, since it indicates we didn't stop somewhere
else or crash.

Also anchor the other match, as Corinna and I noticed earlier.

Will commit in a day or two.  Fixes chng-syms.exp on arm-linux using
gdbserver.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

2004-02-28  Daniel Jacobowitz  <drow@mvista.com>

	* gdb.base/chng-syms.exp: Anchor exit pattern.  Allow
	a breakpoint at exit.

Index: gdb/testsuite/gdb.base/chng-syms.exp
===================================================================
RCS file: /big/fsf/rsync/src-cvs/src/gdb/testsuite/gdb.base/chng-syms.exp,v
retrieving revision 1.3
diff -u -p -r1.3 chng-syms.exp
--- gdb/testsuite/gdb.base/chng-syms.exp	28 Feb 2004 05:40:46 -0000	1.3
+++ gdb/testsuite/gdb.base/chng-syms.exp	28 Feb 2004 17:44:08 -0000
@@ -105,7 +105,10 @@ if  { [gdb_compile "${srcdir}/${subdir}/
 
     gdb_run_cmd
     gdb_expect {
-	-re "Error in re-setting .*No symbol .var1..*Program exited normally.*" {
+	-re "Error in re-setting .*No symbol .var1..*Program exited normally.*$gdb_prompt $" {
+	    pass "running with invalidated bpt condition after executable changes" 
+	}
+	-re "Error in re-setting .*No symbol .var1..*Breakpoint .*,( 0x.* in)? exit .*$gdb_prompt $" {
 	    pass "running with invalidated bpt condition after executable changes" 
 	}
 	-re "$gdb_prompt $" { 

Re: [patch] Fix chng-syms.exp for remote stubs

[Daniel Jacobowitz]

On Sat, Feb 28, 2004 at 12:48:31PM -0500, Daniel Jacobowitz wrote:
> gdb_continue_to_end, used earlier in this file, may set a breakpoint at
> exit.  We can't easily delete that breakpoint, because we're testing for
> another breakpoint's behaviour.  The easiest fix is to allow the breakpoint
> at exit to count as a pass, since it indicates we didn't stop somewhere
> else or crash.
> 
> Also anchor the other match, as Corinna and I noticed earlier.
> 
> Will commit in a day or two.  Fixes chng-syms.exp on arm-linux using
> gdbserver.

I've committed this patch to HEAD and GDB 6.1, after testing both on
i386-pc-linux-gnu.

> 2004-02-28  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* gdb.base/chng-syms.exp: Anchor exit pattern.  Allow
> 	a breakpoint at exit.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [patch] Fix chng-syms.exp for remote stubs

[Andrew Cagney]

>>gdbserver.
> 
> 
> I've committed this patch to HEAD and GDB 6.1, after testing both on
> i386-pc-linux-gnu.

Daniel, what the f- are you doing?  I'm half way through cutting a 
branch, the last thing I need is you being a fly-by nighter checking in 
random stuff.

Re: [patch] Fix chng-syms.exp for remote stubs

[Eli Zaretskii]

> Date: Sat, 28 Feb 2004 22:09:12 -0500
> From: Andrew Cagney <cagney@gnu.org>
> 
> Daniel, what the f- are you doing?  I'm half way through cutting a 
> branch, the last thing I need is you being a fly-by nighter checking in 
> random stuff.

Please let's refrain from such language here, no matter what.  A
volunteer such as Daniel working on a Free Software project doesn't
deserve this, ever.

May I suggest counting to 10 before pressing the SEND button?  I find
this practice very useful in cases like this.