From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4254 invoked by alias); 28 Feb 2004 17:48:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4237 invoked from network); 28 Feb 2004 17:48:32 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 28 Feb 2004 17:48:32 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1Ax8Zj-0004Er-L4 for ; Sat, 28 Feb 2004 12:48:31 -0500 Date: Sat, 28 Feb 2004 17:48:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: [patch] Fix chng-syms.exp for remote stubs Message-ID: <20040228174831.GA16253@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00835.txt.bz2 gdb_continue_to_end, used earlier in this file, may set a breakpoint at exit. We can't easily delete that breakpoint, because we're testing for another breakpoint's behaviour. The easiest fix is to allow the breakpoint at exit to count as a pass, since it indicates we didn't stop somewhere else or crash. Also anchor the other match, as Corinna and I noticed earlier. Will commit in a day or two. Fixes chng-syms.exp on arm-linux using gdbserver. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2004-02-28 Daniel Jacobowitz * gdb.base/chng-syms.exp: Anchor exit pattern. Allow a breakpoint at exit. Index: gdb/testsuite/gdb.base/chng-syms.exp =================================================================== RCS file: /big/fsf/rsync/src-cvs/src/gdb/testsuite/gdb.base/chng-syms.exp,v retrieving revision 1.3 diff -u -p -r1.3 chng-syms.exp --- gdb/testsuite/gdb.base/chng-syms.exp 28 Feb 2004 05:40:46 -0000 1.3 +++ gdb/testsuite/gdb.base/chng-syms.exp 28 Feb 2004 17:44:08 -0000 @@ -105,7 +105,10 @@ if { [gdb_compile "${srcdir}/${subdir}/ gdb_run_cmd gdb_expect { - -re "Error in re-setting .*No symbol .var1..*Program exited normally.*" { + -re "Error in re-setting .*No symbol .var1..*Program exited normally.*$gdb_prompt $" { + pass "running with invalidated bpt condition after executable changes" + } + -re "Error in re-setting .*No symbol .var1..*Breakpoint .*,( 0x.* in)? exit .*$gdb_prompt $" { pass "running with invalidated bpt condition after executable changes" } -re "$gdb_prompt $" {