From: Mark Kettenis <kettenis@chello.nl>
To: davidm@hpl.hp.com
Cc: davidm@hpl.hp.com, kevinb@redhat.com, jjohnstn@redhat.com,
gdb-patches@sources.redhat.com
Subject: Re: make inferior calls work on ia64 even when syscall is pending
Date: Fri, 13 Feb 2004 15:00:00 -0000 [thread overview]
Message-ID: <200402131458.i1DEw4bu000328@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <16428.9442.113820.725379@napali.hpl.hp.com> (message from David Mosberger on Thu, 12 Feb 2004 17:14:10 -0800)
From: David Mosberger <davidm@napali.hpl.hp.com>
Date: Thu, 12 Feb 2004 17:14:10 -0800
>>>>> On Thu, 1 Jan 2004 00:33:23 +0100 (CET), Mark Kettenis <kettenis@chello.nl> said:
Mark> From: David Mosberger <davidm@napali.hpl.hp.com> Date: Wed,
Mark> 31 Dec 2003 12:19:20 -0800
Mark> If the gdb patch looks OK, please check it in.
Mark> David, there are two issues with the patch:
Mark> * I suspect that this approach is Linux-specific. If so, you
Mark> really shouldn't be adding this bit of code to the generic
Mark> ia64_write_pc(). Instead you should create a Linux-specific
Mark> ia64_linux_write_pc() and put it in ia64-linux-tdep.c; you'll
Mark> probably want to call the generic ia64_write_pc() from there.
Mark> Then you must hook in the Linux-specific version if the OSABI
Mark> is GDB_OSABI_LINUX.
Mark> * You should use write_register_pid() instead of
Mark> write_register().
How about the attached patch?
Looks good, except for the "extern" function proptotypes. But I guess
we can't blame you for following the bad example set by ia64-tdep.c.
Kevin, can you approve this patch and create an ia64-tdep.h file with
the function prototypes afterwards?
David, You're not mentioned in the MAINTAINERS file. Do you have a
valid FSF copyright assignment for GDB?
Mark
next prev parent reply other threads:[~2004-02-13 15:00 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-31 19:25 RFA: ia64 portion of libunwind patch J. Johnston
2003-10-31 20:46 ` Andrew Cagney
2003-10-31 22:55 ` David Mosberger
2003-11-07 21:47 ` Andrew Cagney
2003-11-07 22:43 ` David Mosberger
2003-11-07 23:01 ` Andrew Cagney
2003-11-07 23:12 ` David Mosberger
2003-11-07 23:38 ` Andrew Cagney
2003-11-07 23:55 ` David Mosberger
2003-11-08 0:07 ` Andrew Cagney
2003-11-08 0:13 ` Kevin Buettner
2003-11-08 0:27 ` Andrew Cagney
2003-11-08 7:21 ` David Mosberger
2003-11-09 0:13 ` Andrew Cagney
2003-11-10 22:10 ` David Mosberger
2003-11-10 22:43 ` Andrew Cagney
2003-11-10 23:01 ` David Mosberger
2003-11-26 0:11 ` David Mosberger
2003-12-04 2:15 ` David Mosberger
2003-12-04 3:15 ` Kevin Buettner
2003-12-04 23:57 ` J. Johnston
2003-12-05 0:39 ` David Mosberger
2003-12-10 20:58 ` J. Johnston
2003-12-10 22:15 ` David Mosberger
2003-12-12 22:25 ` Kevin Buettner
[not found] ` <davidm@napali.hpl.hp.com>
2003-12-13 4:01 ` Kevin Buettner
2003-12-31 20:19 ` make inferior calls work on ia64 even when syscall is pending David Mosberger
2003-12-31 23:37 ` Mark Kettenis
2004-01-01 2:43 ` David Mosberger
2004-02-13 1:14 ` David Mosberger
2004-02-13 15:00 ` Mark Kettenis [this message]
2004-02-13 15:09 ` Andrew Cagney
2004-02-13 15:12 ` Andrew Cagney
2004-02-13 22:07 ` David Mosberger
2004-02-17 16:21 ` Andrew Cagney
2004-02-23 19:58 ` Kevin Buettner
2004-02-23 21:15 ` Kevin Buettner
2003-11-09 1:34 ` RFA: ia64 portion of libunwind patch Marcel Moolenaar
2003-11-10 21:54 ` David Mosberger
2003-11-10 23:18 ` Marcel Moolenaar
2003-10-31 21:36 ` Marcel Moolenaar
2003-10-31 23:00 ` David Mosberger
2003-10-31 23:42 ` Andrew Cagney
2003-10-31 23:59 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402131458.i1DEw4bu000328@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=davidm@hpl.hp.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jjohnstn@redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox