From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15589 invoked by alias); 13 Feb 2004 15:00:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15582 invoked from network); 13 Feb 2004 15:00:56 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 13 Feb 2004 15:00:56 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i1DEwBS3000246; Fri, 13 Feb 2004 15:58:11 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i1DEwBYE000333; Fri, 13 Feb 2004 15:58:11 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i1DEw4bu000328; Fri, 13 Feb 2004 15:58:04 +0100 (CET) Date: Fri, 13 Feb 2004 15:00:00 -0000 Message-Id: <200402131458.i1DEw4bu000328@elgar.kettenis.dyndns.org> From: Mark Kettenis To: davidm@hpl.hp.com CC: davidm@hpl.hp.com, kevinb@redhat.com, jjohnstn@redhat.com, gdb-patches@sources.redhat.com In-reply-to: <16428.9442.113820.725379@napali.hpl.hp.com> (message from David Mosberger on Thu, 12 Feb 2004 17:14:10 -0800) Subject: Re: make inferior calls work on ia64 even when syscall is pending References: <16371.12104.503371.251351@napali.hpl.hp.com> <200312312333.hBVNXNvg016633@elgar.kettenis.dyndns.org> <16428.9442.113820.725379@napali.hpl.hp.com> X-SW-Source: 2004-02/txt/msg00338.txt.bz2 From: David Mosberger Date: Thu, 12 Feb 2004 17:14:10 -0800 >>>>> On Thu, 1 Jan 2004 00:33:23 +0100 (CET), Mark Kettenis said: Mark> From: David Mosberger Date: Wed, Mark> 31 Dec 2003 12:19:20 -0800 Mark> If the gdb patch looks OK, please check it in. Mark> David, there are two issues with the patch: Mark> * I suspect that this approach is Linux-specific. If so, you Mark> really shouldn't be adding this bit of code to the generic Mark> ia64_write_pc(). Instead you should create a Linux-specific Mark> ia64_linux_write_pc() and put it in ia64-linux-tdep.c; you'll Mark> probably want to call the generic ia64_write_pc() from there. Mark> Then you must hook in the Linux-specific version if the OSABI Mark> is GDB_OSABI_LINUX. Mark> * You should use write_register_pid() instead of Mark> write_register(). How about the attached patch? Looks good, except for the "extern" function proptotypes. But I guess we can't blame you for following the bad example set by ia64-tdep.c. Kevin, can you approve this patch and create an ia64-tdep.h file with the function prototypes afterwards? David, You're not mentioned in the MAINTAINERS file. Do you have a valid FSF copyright assignment for GDB? Mark