Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: Marcel Moolenaar <marcel@xcllnt.net>
Cc: davidm@hpl.hp.com, Andrew Cagney <ac131313@redhat.com>,
	"J. Johnston" <jjohnstn@redhat.com>,
	gdb-patches@sources.redhat.com,
	Kevin Buettner <kevinb@redhat.com>
Subject: Re: RFA: ia64 portion of libunwind patch
Date: Mon, 10 Nov 2003 21:54:00 -0000	[thread overview]
Message-ID: <16304.2269.815957.953193@napali.hpl.hp.com> (raw)
In-Reply-To: <20031109013421.GA742@athlon.pn.xcllnt.net>

>>>>> On Sat, 8 Nov 2003 17:34:21 -0800, Marcel Moolenaar <marcel@xcllnt.net> said:

  Marcel> On Fri, Nov 07, 2003 at 03:12:29PM -0800, David Mosberger wrote:
  >> >>>>> On Fri, 07 Nov 2003 18:01:40 -0500, Andrew Cagney <ac131313@redhat.com> said:

  Andrew> Is fetching the table elements via a function, rather than a
  Andrew> direct access, really that significant an overhead?

  >> Is allocating a scratch buffer in gdb really such a big issue?
  >> It's very late for proposing libunwind API changes.

  Marcel> I think it's very early to have it nailed down.

No, the static code part of libunwind is not really open to
non-backwards-compatible changes anymore.  Things are slightly
different for the dynamic code support, but the static part has too
many users already for making code-breaking changes.  Also,
backwards-compatible changes are of course much easier to add.

  Marcel> Despite ones efforts to create a clean system, there are
  Marcel> always assumptions underlying the code, including the API. I
  Marcel> think it's in the best interest of libunwind if the
  Marcel> developers (yes, you David :-) remain sensitive and open
  Marcel> minded about the how well libunwind interfaces with or
  Marcel> integrates into code that has a need for unwinding.

It's not a good idea to make broad conclusions based on one particular
issue.  In this case, the issue appears to be entirely theoretical
(nobody has produced any numbers showing that, in a realistic
scenario, the current scheme makes, say, gdb startup X% slower, with X
being some large number).  Unless somebody produces such numbers,
I'm certainly not going to change the API in a non-backwards-compatible
fashion.

Perhaps we can find a backwards-compatible way of doing this, in which
case it's _much_ easier to add the feature.

Also, please keep in mind that libunwind is an open-source project.
If you don't like something, or think a feature is missing, submit a
clean patch.

	--david


  reply	other threads:[~2003-11-10 21:54 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-31 19:25 J. Johnston
2003-10-31 20:46 ` Andrew Cagney
2003-10-31 22:55   ` David Mosberger
2003-11-07 21:47     ` Andrew Cagney
2003-11-07 22:43       ` David Mosberger
2003-11-07 23:01         ` Andrew Cagney
2003-11-07 23:12           ` David Mosberger
2003-11-07 23:38             ` Andrew Cagney
2003-11-07 23:55               ` David Mosberger
2003-11-08  0:07                 ` Andrew Cagney
2003-11-08  0:13                   ` Kevin Buettner
2003-11-08  0:27                     ` Andrew Cagney
2003-11-08  7:21                       ` David Mosberger
2003-11-09  0:13                         ` Andrew Cagney
2003-11-10 22:10                           ` David Mosberger
2003-11-10 22:43                             ` Andrew Cagney
2003-11-10 23:01                               ` David Mosberger
2003-11-26  0:11                               ` David Mosberger
2003-12-04  2:15                                 ` David Mosberger
2003-12-04  3:15                                   ` Kevin Buettner
2003-12-04 23:57                                   ` J. Johnston
2003-12-05  0:39                                     ` David Mosberger
2003-12-10 20:58                                       ` J. Johnston
2003-12-10 22:15                                         ` David Mosberger
2003-12-12 22:25                                         ` Kevin Buettner
     [not found]                                 ` <davidm@napali.hpl.hp.com>
2003-12-13  4:01                                   ` Kevin Buettner
2003-12-31 20:19                                     ` make inferior calls work on ia64 even when syscall is pending David Mosberger
2003-12-31 23:37                                       ` Mark Kettenis
2004-01-01  2:43                                         ` David Mosberger
2004-02-13  1:14                                         ` David Mosberger
2004-02-13 15:00                                           ` Mark Kettenis
2004-02-13 15:09                                             ` Andrew Cagney
2004-02-13 15:12                                             ` Andrew Cagney
2004-02-13 22:07                                               ` David Mosberger
2004-02-17 16:21                                                 ` Andrew Cagney
2004-02-23 19:58                                                   ` Kevin Buettner
2004-02-23 21:15                                                 ` Kevin Buettner
2003-11-09  1:34             ` RFA: ia64 portion of libunwind patch Marcel Moolenaar
2003-11-10 21:54               ` David Mosberger [this message]
2003-11-10 23:18                 ` Marcel Moolenaar
2003-10-31 21:36 ` Marcel Moolenaar
2003-10-31 23:00   ` David Mosberger
2003-10-31 23:42     ` Andrew Cagney
2003-10-31 23:59       ` David Mosberger
  -- strict thread matches above, loose matches on Subject: below --
2003-10-24  0:11 J. Johnston
2003-10-24 17:57 ` Kevin Buettner
2003-10-24 18:20   ` J. Johnston
2003-10-24 18:56     ` Kevin Buettner
2003-10-24 21:53       ` Marcel Moolenaar
2003-10-24 23:58         ` Kevin Buettner
2003-10-28 23:53       ` J. Johnston
2003-10-29  1:28         ` Daniel Jacobowitz
2003-10-29  4:48           ` Kevin Buettner
2003-10-29 18:43             ` J. Johnston
2003-10-29 22:48           ` Andrew Cagney
2003-11-04 19:09             ` J. Johnston
2003-11-04 20:48               ` Kevin Buettner
2003-11-14  0:26               ` J. Johnston
2003-11-14  1:17                 ` Kevin Buettner
2003-11-14 20:49                   ` J. Johnston
2003-10-29 23:28         ` Andrew Cagney
2003-11-02 20:39         ` Elena Zannoni
2003-10-29 15:18 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16304.2269.815957.953193@napali.hpl.hp.com \
    --to=davidm@napali.hpl.hp.com \
    --cc=ac131313@redhat.com \
    --cc=davidm@hpl.hp.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    --cc=kevinb@redhat.com \
    --cc=marcel@xcllnt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox