Re: RFC: selected frame in read_var_value

[Daniel Jacobowitz <drow@mvista.com>]

On Mon, Sep 08, 2003 at 09:33:33AM -0400, Andrew Cagney wrote:
> 
> >Is this about what you wanted, and are my comments on the mark?
> 
> Yes, just one pedantic tweak.
> 
> >If so, how do you feel about a mass replacement of the one deprecated
> >construct (deprecated_selected_frame) with the new deprecated construct
> >(deprecated_safe_get_selected_frame) in the places in GDB which use
> >this "if frame arg is NULL, get selected frame" idiom?
> 
> For 6.0, scares the peverbial out of me -> got a convincing argument? 
> :-)  For the mainline, not phased.

Hey Andrew,

This is something I dropped the ball on.  Of course, we're a lot closer
to releasing 6.1 now than we were when I asked you about this in
September.  How would you feel about doing it now?  If you're
uncomfortable, I'll try to dig up the specific instances Debian users
have reported as causing crashes, instead.

For reference, here's the function:

struct frame_info *
deprecated_safe_get_selected_frame (void)
{
  if (!target_has_registers || !target_has_stack || !target_has_memory)
    return NULL;
  return get_selected_frame ();
}

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer