From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30548 invoked by alias); 8 Feb 2004 04:17:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30541 invoked from network); 8 Feb 2004 04:17:09 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 8 Feb 2004 04:17:09 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1ApgNZ-0005cQ-4C; Sat, 07 Feb 2004 23:17:09 -0500 Date: Sun, 08 Feb 2004 04:17:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: RFC: selected frame in read_var_value Message-ID: <20040208041709.GC13033@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com References: <20030801192951.GA2109@nevyn.them.org> <3F329038.5040708@redhat.com> <20030828195501.GB27550@nevyn.them.org> <3F58C35A.3060908@redhat.com> <20030907035325.GA9985@nevyn.them.org> <3F5C852D.2010207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F5C852D.2010207@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00168.txt.bz2 On Mon, Sep 08, 2003 at 09:33:33AM -0400, Andrew Cagney wrote: > > >Is this about what you wanted, and are my comments on the mark? > > Yes, just one pedantic tweak. > > >If so, how do you feel about a mass replacement of the one deprecated > >construct (deprecated_selected_frame) with the new deprecated construct > >(deprecated_safe_get_selected_frame) in the places in GDB which use > >this "if frame arg is NULL, get selected frame" idiom? > > For 6.0, scares the peverbial out of me -> got a convincing argument? > :-) For the mainline, not phased. Hey Andrew, This is something I dropped the ball on. Of course, we're a lot closer to releasing 6.1 now than we were when I asked you about this in September. How would you feel about doing it now? If you're uncomfortable, I'll try to dig up the specific instances Debian users have reported as causing crashes, instead. For reference, here's the function: struct frame_info * deprecated_safe_get_selected_frame (void) { if (!target_has_registers || !target_has_stack || !target_has_memory) return NULL; return get_selected_frame (); } -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer