* [RFA] Use runto_main in testsuite for consistency
@ 2004-02-02 3:49 Fred Fish
2004-02-02 4:07 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Fred Fish @ 2004-02-02 3:49 UTC (permalink / raw)
To: gdb-patches; +Cc: fnf
There are over 160 places in the gdb testsuite where we want to run to main().
Seven of those places use "runto main" rather than "runto_main", probably as
an oversight. This patch makes the testsuite use runto_main consistently.
It was tested with a native i686-pc-linux-gnu testsuite run, with no changes
in the results.
-Fred
2004-02-01 Fred Fish <fnf@redhat.com>
* gdb.base/dump.exp: Use runto_main instead of "runto main".
* gdb.base/finish.exp: Ditto.
* gdb.base/gcore.exp: Ditto.
* gdb.base/huge.exp: Ditto.
* gdb.base/info-proc.exp: Ditto.
* gdb.base/return2.exp: Ditto.
* gdb.threads/gcore-thread.exp: Ditto.
Index: gdb.base/dump.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/dump.exp,v
retrieving revision 1.4
diff -u -p -r1.4 dump.exp
--- gdb.base/dump.exp 28 Aug 2003 18:01:50 -0000 1.4
+++ gdb.base/dump.exp 2 Feb 2004 03:48:29 -0000
@@ -264,7 +264,7 @@ gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}
# Run to main.
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Program failed to run, so remaining tests in this file will automatically fail."
}
Index: gdb.base/finish.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/finish.exp,v
retrieving revision 1.5
diff -u -p -r1.5 finish.exp
--- gdb.base/finish.exp 24 May 2001 01:14:15 -0000 1.5
+++ gdb.base/finish.exp 2 Feb 2004 03:48:29 -0000
@@ -100,7 +100,7 @@ proc finish_void { } {
proc finish_tests { } {
global gdb_prompt
- if { ! [ runto main ] } then {
+ if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/gcore.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gcore.exp,v
retrieving revision 1.5
diff -u -p -r1.5 gcore.exp
--- gdb.base/gcore.exp 13 Oct 2003 16:30:45 -0000 1.5
+++ gdb.base/gcore.exp 2 Feb 2004 03:48:30 -0000
@@ -61,7 +61,7 @@ gdb_expect {
}
}
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/huge.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/huge.exp,v
retrieving revision 1.1
diff -u -p -r1.1 huge.exp
--- gdb.base/huge.exp 8 Jan 2002 01:00:10 -0000 1.1
+++ gdb.base/huge.exp 2 Feb 2004 03:48:30 -0000
@@ -49,7 +49,7 @@ gdb_load ${binfile}
set timeout 30
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/info-proc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/info-proc.exp,v
retrieving revision 1.2
diff -u -p -r1.2 info-proc.exp
--- gdb.base/info-proc.exp 9 Dec 2003 18:19:20 -0000 1.2
+++ gdb.base/info-proc.exp 2 Feb 2004 03:48:30 -0000
@@ -74,7 +74,7 @@ gdb_expect {
gdb_test "info proc" "No current process.*" "info proc without a process"
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/return2.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/return2.exp,v
retrieving revision 1.4
diff -u -p -r1.4 return2.exp
--- gdb.base/return2.exp 23 Jul 2003 18:53:34 -0000 1.4
+++ gdb.base/return2.exp 2 Feb 2004 03:48:30 -0000
@@ -100,7 +100,7 @@ proc return_void { } {
proc return2_tests { } {
global gdb_prompt
- if { ! [ runto main ] } then {
+ if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.threads/gcore-thread.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/gcore-thread.exp,v
retrieving revision 1.6
diff -u -p -r1.6 gcore-thread.exp
--- gdb.threads/gcore-thread.exp 13 Jan 2004 17:08:03 -0000 1.6
+++ gdb.threads/gcore-thread.exp 2 Feb 2004 03:48:31 -0000
@@ -78,7 +78,7 @@ gdb_expect {
}
}
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Use runto_main in testsuite for consistency
2004-02-02 3:49 [RFA] Use runto_main in testsuite for consistency Fred Fish
@ 2004-02-02 4:07 ` Daniel Jacobowitz
2004-02-02 5:17 ` Fred Fish
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2004-02-02 4:07 UTC (permalink / raw)
To: fnf; +Cc: gdb-patches
On Sun, Feb 01, 2004 at 08:49:22PM -0700, Fred Fish wrote:
> There are over 160 places in the gdb testsuite where we want to run to main().
> Seven of those places use "runto main" rather than "runto_main", probably as
> an oversight. This patch makes the testsuite use runto_main consistently.
> It was tested with a native i686-pc-linux-gnu testsuite run, with no changes
> in the results.
Yes, please check this in. The copyright years in a number of these
files probably need to be updated at the same time.
>
> -Fred
>
> 2004-02-01 Fred Fish <fnf@redhat.com>
>
> * gdb.base/dump.exp: Use runto_main instead of "runto main".
> * gdb.base/finish.exp: Ditto.
> * gdb.base/gcore.exp: Ditto.
> * gdb.base/huge.exp: Ditto.
> * gdb.base/info-proc.exp: Ditto.
> * gdb.base/return2.exp: Ditto.
> * gdb.threads/gcore-thread.exp: Ditto.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Use runto_main in testsuite for consistency
2004-02-02 4:07 ` Daniel Jacobowitz
@ 2004-02-02 5:17 ` Fred Fish
0 siblings, 0 replies; 3+ messages in thread
From: Fred Fish @ 2004-02-02 5:17 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
On Sunday 01 February 2004 21:07, Daniel Jacobowitz wrote:
> Yes, please check this in. The copyright years in a number of these
> files probably need to be updated at the same time.
Done.
Here is the patch, as checked in, including ChangeLog and copyright
updates.
-Fred
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.778
diff -u -p -r1.778 ChangeLog
--- ChangeLog 2 Feb 2004 01:57:50 -0000 1.778
+++ ChangeLog 2 Feb 2004 05:13:32 -0000
@@ -1,3 +1,13 @@
+2004-02-01 Fred Fish <fnf@redhat.com>
+
+ * gdb.base/dump.exp: Use runto_main instead of "runto main".
+ * gdb.base/finish.exp: Ditto.
+ * gdb.base/gcore.exp: Ditto.
+ * gdb.base/huge.exp: Ditto.
+ * gdb.base/info-proc.exp: Ditto.
+ * gdb.base/return2.exp: Ditto.
+ * gdb.threads/gcore-thread.exp: Ditto.
+
2004-02-01 Daniel Jacobowitz <drow@mvista.com>
* gdb.threads/thread-specific.exp: Add missing anchor to regexp.
Index: gdb.base/dump.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/dump.exp,v
retrieving revision 1.4
diff -u -p -r1.4 dump.exp
--- gdb.base/dump.exp 28 Aug 2003 18:01:50 -0000 1.4
+++ gdb.base/dump.exp 2 Feb 2004 05:13:32 -0000
@@ -1,4 +1,4 @@
-# Copyright 2002 Free Software Foundation, Inc.
+# Copyright 2002, 2004 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -264,7 +264,7 @@ gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}
# Run to main.
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Program failed to run, so remaining tests in this file will automatically fail."
}
Index: gdb.base/finish.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/finish.exp,v
retrieving revision 1.5
diff -u -p -r1.5 finish.exp
--- gdb.base/finish.exp 24 May 2001 01:14:15 -0000 1.5
+++ gdb.base/finish.exp 2 Feb 2004 05:13:32 -0000
@@ -1,4 +1,4 @@
-# Copyright 2000 Free Software Foundation, Inc.
+# Copyright 2000, 2004 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -100,7 +100,7 @@ proc finish_void { } {
proc finish_tests { } {
global gdb_prompt
- if { ! [ runto main ] } then {
+ if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/gcore.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gcore.exp,v
retrieving revision 1.5
diff -u -p -r1.5 gcore.exp
--- gdb.base/gcore.exp 13 Oct 2003 16:30:45 -0000 1.5
+++ gdb.base/gcore.exp 2 Feb 2004 05:13:32 -0000
@@ -1,4 +1,4 @@
-# Copyright 2002, 2003 Free Software Foundation, Inc.
+# Copyright 2002, 2003, 2004 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -61,7 +61,7 @@ gdb_expect {
}
}
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/huge.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/huge.exp,v
retrieving revision 1.1
diff -u -p -r1.1 huge.exp
--- gdb.base/huge.exp 8 Jan 2002 01:00:10 -0000 1.1
+++ gdb.base/huge.exp 2 Feb 2004 05:13:32 -0000
@@ -1,4 +1,4 @@
-# Copyright 2001 Free Software Foundation, Inc.
+# Copyright 2001, 2004 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -49,7 +49,7 @@ gdb_load ${binfile}
set timeout 30
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/info-proc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/info-proc.exp,v
retrieving revision 1.2
diff -u -p -r1.2 info-proc.exp
--- gdb.base/info-proc.exp 9 Dec 2003 18:19:20 -0000 1.2
+++ gdb.base/info-proc.exp 2 Feb 2004 05:13:32 -0000
@@ -1,4 +1,4 @@
-# Copyright 2002, 2003 Free Software Foundation, Inc.
+# Copyright 2002, 2003, 2004 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -74,7 +74,7 @@ gdb_expect {
gdb_test "info proc" "No current process.*" "info proc without a process"
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/return2.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/return2.exp,v
retrieving revision 1.4
diff -u -p -r1.4 return2.exp
--- gdb.base/return2.exp 23 Jul 2003 18:53:34 -0000 1.4
+++ gdb.base/return2.exp 2 Feb 2004 05:13:32 -0000
@@ -1,4 +1,4 @@
-# Copyright 2000, 2001 Free Software Foundation, Inc.
+# Copyright 2000, 2001, 2004 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -100,7 +100,7 @@ proc return_void { } {
proc return2_tests { } {
global gdb_prompt
- if { ! [ runto main ] } then {
+ if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.threads/gcore-thread.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/gcore-thread.exp,v
retrieving revision 1.6
diff -u -p -r1.6 gcore-thread.exp
--- gdb.threads/gcore-thread.exp 13 Jan 2004 17:08:03 -0000 1.6
+++ gdb.threads/gcore-thread.exp 2 Feb 2004 05:13:32 -0000
@@ -78,7 +78,7 @@ gdb_expect {
}
}
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-02-02 5:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-02 3:49 [RFA] Use runto_main in testsuite for consistency Fred Fish
2004-02-02 4:07 ` Daniel Jacobowitz
2004-02-02 5:17 ` Fred Fish
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox