From: Fred Fish <fnf@public.ninemoons.com>
To: gdb-patches@sources.redhat.com
Cc: fnf@ninemoons.com
Subject: [RFA] Use runto_main in testsuite for consistency
Date: Mon, 02 Feb 2004 03:49:00 -0000 [thread overview]
Message-ID: <200402020349.i123nMGS013729@fred.ninemoons.com> (raw)
There are over 160 places in the gdb testsuite where we want to run to main().
Seven of those places use "runto main" rather than "runto_main", probably as
an oversight. This patch makes the testsuite use runto_main consistently.
It was tested with a native i686-pc-linux-gnu testsuite run, with no changes
in the results.
-Fred
2004-02-01 Fred Fish <fnf@redhat.com>
* gdb.base/dump.exp: Use runto_main instead of "runto main".
* gdb.base/finish.exp: Ditto.
* gdb.base/gcore.exp: Ditto.
* gdb.base/huge.exp: Ditto.
* gdb.base/info-proc.exp: Ditto.
* gdb.base/return2.exp: Ditto.
* gdb.threads/gcore-thread.exp: Ditto.
Index: gdb.base/dump.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/dump.exp,v
retrieving revision 1.4
diff -u -p -r1.4 dump.exp
--- gdb.base/dump.exp 28 Aug 2003 18:01:50 -0000 1.4
+++ gdb.base/dump.exp 2 Feb 2004 03:48:29 -0000
@@ -264,7 +264,7 @@ gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}
# Run to main.
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Program failed to run, so remaining tests in this file will automatically fail."
}
Index: gdb.base/finish.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/finish.exp,v
retrieving revision 1.5
diff -u -p -r1.5 finish.exp
--- gdb.base/finish.exp 24 May 2001 01:14:15 -0000 1.5
+++ gdb.base/finish.exp 2 Feb 2004 03:48:29 -0000
@@ -100,7 +100,7 @@ proc finish_void { } {
proc finish_tests { } {
global gdb_prompt
- if { ! [ runto main ] } then {
+ if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/gcore.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gcore.exp,v
retrieving revision 1.5
diff -u -p -r1.5 gcore.exp
--- gdb.base/gcore.exp 13 Oct 2003 16:30:45 -0000 1.5
+++ gdb.base/gcore.exp 2 Feb 2004 03:48:30 -0000
@@ -61,7 +61,7 @@ gdb_expect {
}
}
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/huge.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/huge.exp,v
retrieving revision 1.1
diff -u -p -r1.1 huge.exp
--- gdb.base/huge.exp 8 Jan 2002 01:00:10 -0000 1.1
+++ gdb.base/huge.exp 2 Feb 2004 03:48:30 -0000
@@ -49,7 +49,7 @@ gdb_load ${binfile}
set timeout 30
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/info-proc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/info-proc.exp,v
retrieving revision 1.2
diff -u -p -r1.2 info-proc.exp
--- gdb.base/info-proc.exp 9 Dec 2003 18:19:20 -0000 1.2
+++ gdb.base/info-proc.exp 2 Feb 2004 03:48:30 -0000
@@ -74,7 +74,7 @@ gdb_expect {
gdb_test "info proc" "No current process.*" "info proc without a process"
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.base/return2.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/return2.exp,v
retrieving revision 1.4
diff -u -p -r1.4 return2.exp
--- gdb.base/return2.exp 23 Jul 2003 18:53:34 -0000 1.4
+++ gdb.base/return2.exp 2 Feb 2004 03:48:30 -0000
@@ -100,7 +100,7 @@ proc return_void { } {
proc return2_tests { } {
global gdb_prompt
- if { ! [ runto main ] } then {
+ if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
Index: gdb.threads/gcore-thread.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/gcore-thread.exp,v
retrieving revision 1.6
diff -u -p -r1.6 gcore-thread.exp
--- gdb.threads/gcore-thread.exp 13 Jan 2004 17:08:03 -0000 1.6
+++ gdb.threads/gcore-thread.exp 2 Feb 2004 03:48:31 -0000
@@ -78,7 +78,7 @@ gdb_expect {
}
}
-if { ! [ runto main ] } then {
+if { ! [ runto_main ] } then {
gdb_suppress_entire_file "Run to main failed, so all tests in this file will automatically fail."
}
next reply other threads:[~2004-02-02 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-02 3:49 Fred Fish [this message]
2004-02-02 4:07 ` Daniel Jacobowitz
2004-02-02 5:17 ` Fred Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402020349.i123nMGS013729@fred.ninemoons.com \
--to=fnf@public.ninemoons.com \
--cc=fnf@ninemoons.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox