Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] solaris9 procfs cleanups
@ 2004-01-29  0:34 Roland McGrath
  2004-01-29 14:01 ` Andrew Cagney
  0 siblings, 1 reply; 3+ messages in thread
From: Roland McGrath @ 2004-01-29  0:34 UTC (permalink / raw)
  To: gdb-patches

I included these changes with a feature patch that is not ready to go in.
But these are just unrelated fixes and should not wait for that other code.
I really think these are obviously correct for using gdb on Solaris 9.  
Can they go in?


Thanks,
Roland


2004-01-21  Roland McGrath  <roland@redhat.com>

	* configure.in (NEW_PROC_API): Also match solaris2.9 for this test.

	* procfs.c: Include <string.h> for str* decls, otherwise warnings.

Index: gdb/configure.in
===================================================================
RCS file: /cvs/src/src/gdb/configure.in,v
retrieving revision 1.140
diff -b -p -u -r1.140 configure.in
--- gdb/configure.in	20 Jan 2004 09:29:16 -0000	1.140
+++ gdb/configure.in	29 Jan 2004 00:32:25 -0000
@@ -623,7 +623,7 @@ if test "${target}" = "${host}"; then
   *-*-unixware* | *-*-sysv4.2* | *-*-sysv5* | *-*-interix* )
       AC_DEFINE(NEW_PROC_API)
       ;;
-  *-*-solaris2.[[678]])
+  *-*-solaris2.[[6789]])
       AC_DEFINE(NEW_PROC_API)
       ;;
   esac
Index: gdb/procfs.c
===================================================================
RCS file: /cvs/src/src/gdb/procfs.c,v
retrieving revision 1.50
diff -b -p -u -r1.50 procfs.c
--- gdb/procfs.c	17 Jan 2004 18:24:15 -0000	1.50
+++ gdb/procfs.c	29 Jan 2004 00:32:26 -0000
@@ -45,6 +45,7 @@ Inc., 59 Temple Place - Suite 330, Bosto
 #include "gdb_wait.h"
 #include <signal.h>
 #include <ctype.h>
+#include <string.h>
 #include "gdb_assert.h"
 #include "inflow.h"
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] solaris9 procfs cleanups
  2004-01-29  0:34 [PATCH] solaris9 procfs cleanups Roland McGrath
@ 2004-01-29 14:01 ` Andrew Cagney
  2004-01-29 21:56   ` Roland McGrath
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2004-01-29 14:01 UTC (permalink / raw)
  To: Roland McGrath; +Cc: gdb-patches

> I included these changes with a feature patch that is not ready to go in.
> But these are just unrelated fixes and should not wait for that other code.
> I really think these are obviously correct for using gdb on Solaris 9.  
> Can they go in?

Yes, but include "gdb_string.h" instead of <string.h> (which meas also 
tweaking Makefile.in).

Andrew


> 2004-01-21  Roland McGrath  <roland@redhat.com>
> 
> 	* configure.in (NEW_PROC_API): Also match solaris2.9 for this test.
> 
> 	* procfs.c: Include <string.h> for str* decls, otherwise warnings.
> 
> Index: gdb/configure.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.in,v
> retrieving revision 1.140
> diff -b -p -u -r1.140 configure.in
> --- gdb/configure.in	20 Jan 2004 09:29:16 -0000	1.140
> +++ gdb/configure.in	29 Jan 2004 00:32:25 -0000
> @@ -623,7 +623,7 @@ if test "${target}" = "${host}"; then
>    *-*-unixware* | *-*-sysv4.2* | *-*-sysv5* | *-*-interix* )
>        AC_DEFINE(NEW_PROC_API)
>        ;;
> -  *-*-solaris2.[[678]])
> +  *-*-solaris2.[[6789]])
>        AC_DEFINE(NEW_PROC_API)
>        ;;
>    esac
> Index: gdb/procfs.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/procfs.c,v
> retrieving revision 1.50
> diff -b -p -u -r1.50 procfs.c
> --- gdb/procfs.c	17 Jan 2004 18:24:15 -0000	1.50
> +++ gdb/procfs.c	29 Jan 2004 00:32:26 -0000
> @@ -45,6 +45,7 @@ Inc., 59 Temple Place - Suite 330, Bosto
>  #include "gdb_wait.h"
>  #include <signal.h>
>  #include <ctype.h>
> +#include <string.h>
>  #include "gdb_assert.h"
>  #include "inflow.h"
>  
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] solaris9 procfs cleanups
  2004-01-29 14:01 ` Andrew Cagney
@ 2004-01-29 21:56   ` Roland McGrath
  0 siblings, 0 replies; 3+ messages in thread
From: Roland McGrath @ 2004-01-29 21:56 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: gdb-patches

> Yes, but include "gdb_string.h" instead of <string.h> (which meas also 
> tweaking Makefile.in).

Done.


Thanks,
Roland


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-01-29 21:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-01-29  0:34 [PATCH] solaris9 procfs cleanups Roland McGrath
2004-01-29 14:01 ` Andrew Cagney
2004-01-29 21:56   ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox