From: Andrew Cagney <cagney@gnu.org>
To: Roland McGrath <roland@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] solaris9 procfs cleanups
Date: Thu, 29 Jan 2004 14:01:00 -0000 [thread overview]
Message-ID: <40191184.3080908@gnu.org> (raw)
In-Reply-To: <200401290034.i0T0YSM0017092@magilla.sf.frob.com>
> I included these changes with a feature patch that is not ready to go in.
> But these are just unrelated fixes and should not wait for that other code.
> I really think these are obviously correct for using gdb on Solaris 9.
> Can they go in?
Yes, but include "gdb_string.h" instead of <string.h> (which meas also
tweaking Makefile.in).
Andrew
> 2004-01-21 Roland McGrath <roland@redhat.com>
>
> * configure.in (NEW_PROC_API): Also match solaris2.9 for this test.
>
> * procfs.c: Include <string.h> for str* decls, otherwise warnings.
>
> Index: gdb/configure.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.in,v
> retrieving revision 1.140
> diff -b -p -u -r1.140 configure.in
> --- gdb/configure.in 20 Jan 2004 09:29:16 -0000 1.140
> +++ gdb/configure.in 29 Jan 2004 00:32:25 -0000
> @@ -623,7 +623,7 @@ if test "${target}" = "${host}"; then
> *-*-unixware* | *-*-sysv4.2* | *-*-sysv5* | *-*-interix* )
> AC_DEFINE(NEW_PROC_API)
> ;;
> - *-*-solaris2.[[678]])
> + *-*-solaris2.[[6789]])
> AC_DEFINE(NEW_PROC_API)
> ;;
> esac
> Index: gdb/procfs.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/procfs.c,v
> retrieving revision 1.50
> diff -b -p -u -r1.50 procfs.c
> --- gdb/procfs.c 17 Jan 2004 18:24:15 -0000 1.50
> +++ gdb/procfs.c 29 Jan 2004 00:32:26 -0000
> @@ -45,6 +45,7 @@ Inc., 59 Temple Place - Suite 330, Bosto
> #include "gdb_wait.h"
> #include <signal.h>
> #include <ctype.h>
> +#include <string.h>
> #include "gdb_assert.h"
> #include "inflow.h"
>
>
next prev parent reply other threads:[~2004-01-29 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-29 0:34 Roland McGrath
2004-01-29 14:01 ` Andrew Cagney [this message]
2004-01-29 21:56 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40191184.3080908@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox